446360 - Display error when a (half-)empty login form is submitted

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

While building out my automated Selenium testcases for AMO, I noticed that the login form validation on https://preview.addons.mozilla.org/en-US/firefox/users/login isn't working.

Steps to Reproduce:

1. Load https://preview.addons.mozilla.org/en-US/firefox/users/login
2. Clear the textfields
3. Click "Log in"

Expected Results:

As on production, it should throw "Wrong username or password!"

Actual Results:

"Please confirm your user account first with the code you received by email.

A link to activate your user account was sent by email to your address . You have to click it before you can log into Firefox Add-ons.

If you did not receive the confirmation email, make sure your email service did not mark it as "junk mail" or "spam". If you need to, you can have us resend the confirmation message to your email address mentioned above."

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Brandon: is this a potential security risk?

Comment 2

[Fred Wenzel [:wenzel]]

The preview db is out of sync (as usual :-/ I thought that was auto-updated somehow?) -- other that that, this is a dupe of bug 434540, sorry.

Comment 3

[Fred Wenzel [:wenzel]]

Reopening: While this problem is fixed in production, I think we should throw the usual "this field must not be empty" error if you submit the form with either field empty. Putting it into the database in the first place when it's clearly invalid is not good.

I'll tackle this as part of 3.4.7.

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: throw error on empty login field

This throws the "bad login" error if any of the two fields is empty (instead of even trying to find the right user in the DB).

Comment 5

[u278084]

Comment on attachment 333578 [details] [diff] [review]
throw error on empty login field

Looks good from my testing

Comment 6

[Fred Wenzel [:wenzel]]

I checked this in to r17656. Thanks!

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on preview.