447604 - Url in QA-Menu for Recent Checkins should be moved from CVS to hg comm-central

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Tobias Fischer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008072208 Mnenhy/0.7.5.20005 SeaMonkey/2.0a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a1pre) Gecko/2008072208 Mnenhy/0.7.5.20005 SeaMonkey/2.0a1pre

Current Entry in QA-Menu links to CVS Checkins Today. 

Since SeaMonkey has moved to comm-central, the Entry should give an Link to an Page which lists the current checkins into the hg/Mercurial Repository, like: http://hg.mozilla.org/index.cgi/comm-central/ and probably in combination with http://hg.mozilla.org/index.cgi/mozilla-central/summary
so it was easy to take a look into the recent checkins. 

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Frank Wein [:mcsmurf]]

Maybe it should open two new tabs, one for comm-central and one for mozilla-central?

Comment 2

[Tobias Fischer]

Hmm, open one Tab for: 
http://hg.mozilla.org/comm-central/index.cgi/pushloghtml 
and another for: 
http://hg.mozilla.org/mozilla-central/index.cgi/pushloghtml

might be a little bit unusual, but I have no better Idea. 
I am just asking me, if there is any way to show only the SeaMonkey related commits (hg pushes) into mozilla-central?

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> might be a little bit unusual, but I have no better Idea. 
> I am just asking me, if there is any way to show only the SeaMonkey related
> commits (hg pushes) into mozilla-central?

Apart from NPOTB stuff or things in /browser, or things we override, the vast majority of items checked into mozilla-central are SeaMonkey related.

Comment 4

[Tobias Fischer]

Attachment: Handmade Draft for possible Changes in debugQAMenuOverlay.xul

This Draft shows an possible, but not really elegant Way to get an simple way to see the recent ccheckins into comm-central and mozilla-central from QA-Menu. 

I have not found an easy Method to open multiple Tabs from an Menuitem. oncommand=loadTabs seems not to work, because it was not defined (in Navigator.xul or so). So I have to add an new Item for mozilla-central. 

Also the naming for the Items might be improved, if there was an possibility to open both summary-sites from one Menuitem, something like "Recent Checkins" or Recent Pushs" will fit. 

Would be nice, if someone can take a look into this, and give some suggestions.

Comment 5

[Robert Kaiser]

This links to the repos, not to the pushlogs ;-)
http://hg.mozilla.org/mozilla-central/index.cgi/pushloghtml and http://hg.mozilla.org/comm-central/index.cgi/pushloghtml would be the real push logs, which even will gain query-by-date features in the next few weeks.

Comment 6

[Tobias Fischer]

Attachment: Add link to comm-central and mozilla-central pushlog in QA-Menu, remove CHS-Checkins

Add now an real diff of an possible fix. Still need some polish I think.

Comment 7

[Tobias Fischer]

Bah, mean remove "CVS Checkins Today"

Comment 8

[Robert Kaiser]

Comment on attachment 336259 [details] [diff] [review]
Add link to comm-central and mozilla-central pushlog in QA-Menu, remove CHS-Checkins

As the QA menu is there in Alphas (we usually only remove it from RCs and finals, I think) we should try to get this easy fix into the first Alpha, if possible.

Comment 9

[Tobias Fischer]

Well, think this one is better than nothing for the first Alpha. 

I will try to work on a better Patch, but can't do anything this week.

Comment 10

[Manuel Reimer]

Attachment: Patch which opens two tabs in current window

Comment 11

[Tobias Fischer]

Have tested Manuels Patch locally and it works really fine, just like I would have done it, if only I could. ;)

Comment 12

[[e-mail]]

Ted, is there a reliable method to select today's checkins? I find that sometimes "today" is in the future, so I've taking to using http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=yesterday&enddate=now

Comment 13

[(not currently active) Ted Mielczarek]

I think "today" without any time is 9am for some reason. You can do "today at 00:00" to "now" to get things only checked in since midnight, or "24 hours ago" to "now" to get everything in the last 24 hours.

http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=today+at+00%3A00&enddate=now

http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=24+hours+ago&enddate=now

Comment 14

[[e-mail]]

Comment on attachment 337637 [details] [diff] [review]
Patch which opens two tabs in current window

* Need better URLs
* Doesn't work on the Mac if no windows are open

Comment 15

[Manuel Reimer]

Attachment: Second patch

This patch uses openTopWin for the first URL and uses the returned window reference of this function to open the second in a tab.

Comment 16

[Tony Mechelynck [:tonymec]]

- The latest patch seems to have dropped access to the latest mozilla-central checkins (where Core checkins are relevant for SeaMonkey). Is it intentional? Or have I misunderstood?
- Why not two menuitems so that the user can choose? E.g. "QA => Latest comm-central checkins" and "QA => Latest mozilla-central checkins" I don't like the idea of opening _two_ URLs for _one_ menuitem.

Comment 17

[Tobias Fischer]

(In reply to comment #16)
> - The latest patch seems to have dropped access to the latest mozilla-central
> checkins (where Core checkins are relevant for SeaMonkey). Is it intentional?
> Or have I misunderstood?

The latest Patch open comm-central-pushlog (24h ago-now) onTopWin (actual Window/Tab, hopefully open a new Browser-Window on Mac when there is none) wich hold/get the focus, and add a new tab for the mozilla-central-pushlog (24h ago-now) in background. 

I have tested this locally and it works fine on Windows. 

> - Why not two menuitems so that the user can choose? E.g. "QA => Latest
> comm-central checkins" and "QA => Latest mozilla-central checkins" I don't like
> the idea of opening _two_ URLs for _one_ menuitem.

To load one Site and open another Tab from one Menu-Item is really a little unusual. But this gives easy access to the recent changes in both repositories of interest, and shows, that most of mozilla-central checkins are also important for SeaMonkey.

Comment 18

[[e-mail]]

Comment on attachment 338270 [details] [diff] [review]
Second patch

Sadly this still doesn't work on the Mac because openTopWin might return a window that hasn't loaded its chrome yet.

What could work is to move OpenURLArrayInTabs from history.js to utilityOverlay.js and call that instead.

Comment 19

[Karsten Düsterloh]

Comment on attachment 338270 [details] [diff] [review]
Second patch

This won't work on Mac, when no normal window is open. w will then get set to the hidden window, which  doesn't even have a tabbrowser, let alone functions from navigator.js.

AFAICT, you need to use the window mediator to check for a browser window and maybe open a new one before trying to touch its tabbrowser.

Comment 20

[[e-mail]]

(In reply to comment #19)
> AFAICT, you need to use the window mediator to check for a browser window and
> maybe open a new one before trying to touch its tabbrowser.
Just opening a new one isn't sufficient; you have to wait for it to load.

Comment 21

[Robert Kaiser]

Somehow, this sounds to me like it would turn into a neverending story (and yes, I think we really should have some functionality somewhere to make this easier). I start to think we should take attachment 336259 [details] [diff] [review] for Alpha 1 and then work on improving this to a single item, maybe with creating a generalized function we can call.

Comment 22

[Tobias Fischer]

Attachment: Simple Patch, One Otem for comm-central, added new for mozilla-central, Query 24h to now

Overhaul of attachment 336259 [details] [diff] [review], this simple changes the Menu-Item-Name and URL to comm-central, add a new Item for mozilla-central, Daterange 24h ago to now. 

This should be only a temporary fix, only for the first Alpha-Release.

Comment 23

[[e-mail]]

Comment on attachment 338646 [details] [diff] [review]
Simple Patch, One Otem for comm-central, added new for mozilla-central, Query 24h to now

>+        <menuitem label="HG comm-central Pushs"
Did you mean "Pushes" or "pushlog"?

>+                  oncommand="openTopWin('http://http://hg.mozilla.org/comm-central/pushloghtml?startdate=24+hours+ago&enddate=now');"/>
Doubled http:// and incorrect bare &

>+                  oncommand="openTopWin('http://hg.mozilla.org/mozilla-central/pushloghtml?startdate=24+hours+ago&enddate=now');"/>
Bare & is invalid XML (and dubious in HTML).

Next time try it out locally first please?

Comment 24

[Tobias Fischer]

Attachment: Corrected simple patch (tested only on Windows)

Hopefully fixed Version of the simple (temporary) Patch as Neil has said. 

This time I have tested the Patch locally on Windows, i will apologize to have not the last time.

Comment 25

[[e-mail]]

Comment on attachment 339434 [details] [diff] [review]
Corrected simple patch (tested only on Windows)

OK so the patch works but I just want to get some confirmation of the wording that we want to use here.

Comment 26

[Tobias Fischer]

(In reply to comment #25)
> (From update of attachment 339434 [details] [diff] [review])
> OK so the patch works but I just want to get some confirmation of the wording
> that we want to use here.

Thanks for the review. And I am pretty unsure (and not lucky) about the wording too, but I have no better idea. Also I am going into holiday tomorrow, so someone else should pick this up to get it fixed for Alpha 1. 

But this simple patch should be only a temporary fix, a fixed Version of attachment 338270 [details] [diff] [review] would be better.

Comment 27

[Robert Kaiser]

Comment on attachment 339434 [details] [diff] [review]
Corrected simple patch (tested only on Windows)

a=me for Alpha 1, including a possible improvement of the labels

Comment 28

[[e-mail]]

Pushed changeset 57c9550d7c96 to comm-central.

The wording I finally went with is "Recent <repo> Checkins".

Comment 29

[Serge Gautherie (:sgautherie)]

Comment on attachment 339434 [details] [diff] [review]
Corrected simple patch (tested only on Windows)

http://hg.mozilla.org/comm-central/rev/3bada1bdfec9
I backed this patch out to verify that it caused bug 456235.

Comment 30

[Serge Gautherie (:sgautherie)]

(In reply to comment #29)

http://hg.mozilla.org/comm-central/rev/b4ffcc730024
I restored the patch, as the backout did not help.

Comment 31

[Manuel Reimer]

Attachment: Another version of the "one menu entry only" patch.

I don't know if there is still someone interested, but this uses the OpenURLArrayInTabs idea of Neil to open both items in tabs.

I planned first to fix "openTopWin" to be able to open tabs, but some of the stuff in the function seems to have been added by a security bug I can't access. IMHO it is inconsistent to be only able to open multiple URLs separated by newline characters if there is no browser window open.

Comment 32

[Robert Kaiser]

I filed bug 458438 for the "one menu entry only" issue. I'm adding a function for opening an array of URLs in tabs in bug 370698, which should help a lot with implementing this.