448680 - Starting <video> playback causes master volume to jump to max

Status: VERIFIED FIXED

Description

[Tom Adams]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1a2pre) Gecko/2008073102 Minefield/3.1a2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1a2pre) Gecko/2008073102 Minefield/3.1a2pre

Pressing "play" and activating a <canvas> video causes the system's volume to jump to maximum.

Reproducible: Always

Steps to Reproduce:
1. Visit, for example, http://www.double.co.nz/video_test/test1.html
2. Turn your volume down to a sensible level
3. Press a play button
Actual Results:  
Video begins playing with the master volume set to maximum.

Expected Results:  
Video begins playing without changing the system's volume.

Notice that in this case after pausing and resuming the master volume is not affected.

Comment 1

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1a2pre) Gecko/2008073103 Minefield/3.1a2pre

My system can't handle it; I only hear creaky unrecognizably deformed sound but not loud. 

Comment 2

[Ria Klaassen (not reading all bugmail)]

I can only hear what it was meant to be when I first close the tab and then the available memory has gone down to 2 MB RAM.

Comment 5

[Jesse Ruderman]

This is the first Firefox bug I've read about capable of causing physical harm to users.  It should be fixed ASAP.

Comment 6

[Biju]

I assume this is CONFIRMED.

Comment 7

[John Drinkwater (:beta)]

Can confirm here with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1a2pre) Gecko/20080809020910 Minefield/3.1a2pre

Comment 10

[cajbir (:cajbir)]

Created attachment 344996 [details] [diff] [review]
Fix volume issues

Removes dead code from nsAudioStream and fixes volume issues related to it. Instead of using hardware volume control support I adjust the sound sample value before writing it. libsydneyaudio has patchy hardware volume control support hence the reason this approach is taken.

Comment 11

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 344996 [details] [diff] [review]
Fix volume issues

Move the multiplication by mVolume up inside the floorf, as we discussed.

Comment 12

[cajbir (:cajbir)]

Created attachment 344998 [details] [diff] [review]
Address review comment

Comment 13

[Robert Kaiser]

Does this also take muting into account? I saw muting the <video> actually muting the whole hardware audio channel, which is the master in my case - and I think we actually should only mute the one <video> this was selected on.

Comment 14

[cajbir (:cajbir)]

Yes, muting only mutes the current playing video and does not affect the hardware channel in any way.

Comment 15

[cajbir (:cajbir)]

http://hg.mozilla.org/mozilla-central/rev/5833ad22f1a7

Comment 16

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090217 Shiretoko/3.1b3pre
and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090217 Minefield/3.2a1pre

Comment 17

[Yakir Sitbon]

Hey.. I'm using with Nightly version (firefox-nightly 34.0a1.20140722-1), and I get this problem too.

I'm using with GNOME 3.12.2, so what I can to do?

Comment 18

[Paul Adenot (:padenot)]

This is a super old bug, and what you are talking about will be fixed real soon, but in the meantime, you can add this to /etc/pulse/daemon.conf:

flat-volumes = no

Comment 19

[Yakir Sitbon]

Hey Paul.
I do what you say and it's fixes my problem. Thank you ! :)