449066 - make Ogg Theora <video> tag support build on FreeBSD

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Jeremy Lea]

Attachment: Make Ogg Theora build on FreeBSD

I could have sworn that I filed this already, but it's not there...  Anyway.

The new ogg theora code does not compile on FreeBSD, and probably any other platform other than the big three.  This patch gets it to work on FreeBSD.  The bulk of the patch is a rewrite of the OSS driver so it compiles on FreeBSD.  I have not tested this yet, since my FreeBSD box is currently headless...  that should be fixed by the end of the day.  The changes should work on Linux though, and would provide support if ALSA was not found there.

Comment 1

[Tyler Downer [He/Him]]

Is this related to Firefox? It sounds like a FreeBSD issue, or Ogg.

Comment 2

[Jeremy Lea]

Is the new title better?  Generally if a bug has a patch, it is not an accident ;-)

Comment 3

[cajbir (:cajbir)]

That file is actually part of the Annodex browser_plugin library. Ideally any changes we make should be fed back to them so I'll check with them to see what their plans are here.

Can you confirm if your changes worked on your FreeBSD box? I can test on Linux.

Comment 5

[Jeremy Lea]

Attachment: WIP patch v2

Updated patch that not only compiles but plays audio on FreeBSD and Linux.  The patch still needs a little work.  I would like to get the timing to use the position rather than the wall clock, since that would be much more reliable.  I don't know why it doesn't work now.  The code reports the right position, but it stutters. 

Also, it may need some tweaking to get some sleeps right...  But anyway, it works as well as ALSA on my Ubuntu VM, so it could be used as a fallback on Linux if ALSA is not available.  This should work on other OSS systems too.

Comment 6

[Marco Perez [:mpk]]

Attachment: updated patch for current trunk (mozilla-central)

There must have been a few changes on the trunk, because the patch doesn't
apply cleanly any longer. This is a stripped down version, which helped me
test the new multimedia browser capabilities on FreeBSD Stable.

I also have this stuttering. Not with all files, but especially when playing
http://www.double.co.nz/video_test/test2.html . I could help out with building
and/or testing if desired.

Comment 7

[Jeremy Lea]

Attachment: WIP patch v3

This is a revised patch, which seems to work well for me on Linux and FreeBSD.  It removes the repeated malloc()/free()ing of the ring buffer with a single static buffer, converts writer thread to a state machine and implements playing and pausing properly.  It needs some cleaning and polishing, but it seems to work...

Comment 8

[Marco Perez [:mpk]]

Attachment: slightly modified v3 (fixed for mozilla-central)

Fixing bug 449754 broke the original v3 patch on mozilla-central (it still works
fine on the release branch mozilla-1.9.1 though).

Comment 9

[Jeremy Lea]

Attachment: liboggplay part

This is just the liboggplay part, submitted to annodex as https://trac.annodex.net/ticket/462.  Do I need to get this into a patch format with changes to README_MOZILLA? Other two parts coming in a second.

I'd like to get these into 1.9.1, so that it builds out the box...

Comment 10

[Jeremy Lea]

Attachment: liboggz part

This bit is not controversial...

Comment 11

[Jeremy Lea]

Argh... submitted upstream as https://trac.annodex.net/ticket/463.

Comment 12

[Jeremy Lea]

Attachment: libsydneyaudio part

This is the big fish...  revised OSS support.  Submitted upstream as https://trac.annodex.net/ticket/464.  This builds and works on Linux (Ubuntu) and FreeBSD.  Seemed a little laggy on Linux, but that might be because it's a VM, and there are other lag bugs floating around.

Comment 13

[cajbir (:cajbir)]

Comment on attachment 372157 [details] [diff] [review]
liboggz part

Please add a patch file and update update.sh so that the patch gets applied net time I refresh. Also add to README_MOZILLA referencing this bug number and the patch file. r+ with that.

Comment 14

[cajbir (:cajbir)]

Comment on attachment 372156 [details] [diff] [review]
liboggplay part

r+ with addition of README_MOZILLA, patch file and update.sh change as mentioned in previous comment.

Comment 15

[cajbir (:cajbir)]

Comment on attachment 372159 [details] [diff] [review]
libsydneyaudio part

r+ with  update to README_MOZILLA, a .patch file and a line added to update.sh to apply that patch. See the os/2 patches in the media/libsydneyaudio directory for example.

Comment 16

[cajbir (:cajbir)]

Comment on attachment 372156 [details] [diff] [review]
liboggplay part

This patch has been picked up from upstream.

Comment 18

[Marco Perez [:mpk]]

WFM since the fix for bug 556455 landed. On x86 as well as on x86_64. I think it's safe to assume that this is fixed now. :-)