449367 - comm-central doesn't allow full-configures for l10n purposes

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Mark Banner (:standard8)]

I'm not sure if we're going to need to fix this or not, I've just been playing around with Thunderbird's build system and I've found that the instructions at http://developer.mozilla.org/en/docs/Creating_a_Language_Pack won't work for comm-central.

The problem here is that when we now have:

ac_add_options --disable-compile-environment

and run:

make -f client.mk configure

it only runs the comm-central configure, not the mozilla-central one as well. This means the make langpack-ab-CD step then fails because the directories aren't available.

If I remove the --disable-compile-environment flag, it then complains that <objdir>/mozilla/config/nsinstall isn't available.

So maybe there's several issues here, and it may be better to hold off until we know a bit more about what mozilla-central will look like.

Comment 1

[Robert Kaiser]

Attachment: call Mozilla configure even with disabled compile environment

Mark, could you test if this patch fixes that problem you had there?

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 334035 [details] [diff] [review]
call Mozilla configure even with disabled compile environment

Yep, this fixes it. I've not verified the contents fully, but it certainly seems to work and come out with the right files in the xpi.

Comment 3

[Robert Kaiser]

Pushed as http://hg.mozilla.org/comm-central/index.cgi/rev/d126f83d6906 - I hope this works correctly now, please file any other issues that come up!