All users were logged out of Bugzilla on October 13th, 2018

Get rid of remaining SVG build options in comm-central

RESOLVED FIXED in mozilla1.9.1a2

Status

RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: kairo, Assigned: kairo)

Tracking

Trunk
mozilla1.9.1a2
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
The comm-central doesn't need to care about SVG. Investigating what we need to port from bug 450495 I realized that we have removed most of the SVG stuff already at checkin, but a few things remain that should still be cleaned up.
I could do this as part of bug 445141 but it might be better to do the whole task in smaller chunks.

The most problematic case is http://mxr.mozilla.org/comm-central/source/mail/installer/windows/packages-static#393 but with the removal of vast parts of this that we already did I'm not sure if it works correctly at the moment, and removing the ifdef doesn't change more than adding two bogus warnings at packaging time for current default Thunderbird builds.
(Assignee)

Comment 1

10 years ago
Created attachment 334179 [details] [diff] [review]
remove the rest of SVG definitions

This patch removes the rest of SVG definitions in comm-central. I was informed that bug 366126 enabled SVG in Thunderbird, so that ifdef is actually even more unneeded as default builds have it anyway.
Assignee: nobody → kairo
Status: NEW → ASSIGNED
Attachment #334179 - Flags: review?(bugzilla)
(Assignee)

Updated

10 years ago
No longer blocks: 450495
Depends on: 450495
Attachment #334179 - Flags: review?(bugzilla) → review+
(Assignee)

Comment 2

10 years ago
Checked in as http://hg.mozilla.org/comm-central/index.cgi/rev/13eae6fc3733
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Does this mean |ac_add_options --disable-svg| support is somehow "reduced" ?
Target Milestone: --- → seamonkey2.0alpha
(In reply to comment #3)
> Does this mean |ac_add_options --disable-svg| support is somehow "reduced" ?

No. Options will still get passed to the core mozilla configure. All it reduces is the extra time to configure comm-central (which isn't much in this case).
(Assignee)

Updated

10 years ago
Component: Build Config → Build Config
Product: SeaMonkey → MailNews Core
QA Contact: build-config → build-config
Target Milestone: seamonkey2.0alpha → ---
Target Milestone: --- → mozilla1.9.1a2
(In reply to comment #4)

Actually, it looks like it does ... because SeaMonkey was missing some related #ifdef:
I filed bug 541267.
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.