451185 - add a build target to compare bin/ and the package list

Status: RESOLVED FIXED

Description

[Robert Kaiser]

To be able to check if our package lists are OK, it would be nice to have a build target that outputs a diff of the dist/bin directory and the files in the package list. This gives us a fast check what we aren't packaging and what we have in the package list that isn't built any more. Our builder boxes could even execute that so we can look into their logs and see that package diff easily.

Comment 1

[Robert Kaiser]

Created attachment 334470 [details] [diff] [review]
add package-compare target

This adds a "package-compare" target callable from the objdir toplevel. I tested this on Linux, I hope it works on Windows (testing wanted!) - Mac should not produce any output as we have no package manifest there currently.

Comment 2

[Robert Kaiser]

Comment on attachment 334470 [details] [diff] [review]
add package-compare target

>diff --git a/suite/installer/Makefile.in b/suite/installer/Makefile.in
>+	cd $(DIST); find -L bin -type f | sort > bin-list.txt

Note to self: We need a var for the find options that varies per-platform, as -L (dereference symlinks) doesn't work on Windows.

Comment 3

[Robert Kaiser]

Created attachment 334554 [details] [diff] [review]
add package-compare target, v2

Here's a new version, updated for what testing on Windows revealed (thanks mcsmurf!).

Comment 4

[Robert Kaiser]

checked in as http://hg.mozilla.org/comm-central/index.cgi/rev/5d26645ae929