451981 - add a build target to compare bin/ and the package list

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

Attachment: Code Fix

+++ This bug was initially created as a clone of Bug #451185 +++

Robert's comment:

To be able to check if our package lists are OK, it would be nice to have a build target that outputs a diff of the dist/bin directory and the files in the package list. This gives us a fast check what we aren't packaging and what we have in the package list that isn't built any more. Our builder boxes could even execute that so we can look into their logs and see that package diff easily.

My comment:

I agree, we can check it every so often (maybe even put it in the release steps for each release/signoff stage) and hopefully we can keep track of core better.

Comment 1

[Phil Ringnalda (:philor)]

Nice, depending on how you count I see between three and five separate bugs in the output. But, does it really need to finish up with |make[1]: [package-compare] Error 1 (ignored)|? (Also, I'd really love wildcard expansion, and a pony.)

Comment 2

[Mark Banner (:standard8)]

(In reply to comment #1)
> Nice, depending on how you count I see between three and five separate bugs in
> the output. But, does it really need to finish up with |make[1]:
> [package-compare] Error 1 (ignored)|?

Unfortunately yes, because diff will return 1 if some differences were found. The only sensible way to get around that is to add the - to the makefile instruction to tell make to ignore it (otherwise you'd end up with |make[1]: *** package-compare] Error 1| etc

> (Also, I'd really love wildcard expansion, and a pony.)

I'm sure if you want them that much you can make them happen :-P

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 335291 [details] [diff] [review]
Code Fix

Feels more like it ought to be a script that lives in /tools/ (which would have the added advantage of letting me use it on Firefox) rather than a build target, but I'll take what I can get, thanks.

Comment 4

[Robert Kaiser]

Phil:
Possibly, but then it's more or less just three commands, easy to make up manually, it needs the preprocessed manifest, which we create right in that makefile, and a makefile target is easy to call from buildbot.

Comment 5

[Mark Banner (:standard8)]

Checked in, changeset id: 236:26456d344968