452914 - Multiple problems with editflagtypes.cgi interface

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: General, defect, P1)

Description

[Reed Loden [:reed]]

I tried working on some flags for bmo tonight, and I ran into some problems:
* Impossible to add <product> :: __Any__ -- selecting a product removes __Any__ from the component listing
* Selecting another product and then selecting the __Any__ product again results in empty component drop-down

These are some JS errors I received while trying this:
Error: control.options is undefined
Source File: https://bugzilla.mozilla.org/js/productform.js
Line: 414
Error: item is undefined
Source File: https://bugzilla.mozilla.org/js/productform.js
Line: 282

This currently means I can't add flags to entire products right now, which is very bad.

Comment 1

[Frédéric Buclin]

I cannot reproduce upstream, neither on tip nor on 3.2rc1.

Comment 2

[Reed Loden [:reed]]

mkanat, is this due to some bmo-only changes? I need this fixed ASAP.

Comment 3

[Max Kanat-Alexander]

Ah, yes, it's due to the addition of cf_fixed_in to productform.js, I'll bet.

Comment 4

[Max Kanat-Alexander]

This has been fixed. I've also fixed the same bug in a few other places. The fix is in my repo:

Committing to: /var/www/html/everythingsolved.com/bzr/mozilla/3.2/
modified template/en/default/admin/flag-type/edit.html.tmpl
modified template/en/default/admin/flag-type/list.html.tmpl
modified template/en/default/request/queue.html.tmpl
Committed revision 6131.

Comment 5

[Dave Miller [:justdave]]

This is live on bugzilla-stage-tip and will be in production soon.

Comment 6

[timeless]

tested based on comment 0 and this seems to work