------- Comment #68 From email@example.com 2008-09-03 05:11:44 PDT There are two oversight. fx126.96.36.199 is still exploitable. http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/feeds/src/FeedWriter.js&rev=188.8.131.52&mark=635#623 This is exploitable. I'll attach a testcase. http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/components/feeds/src/FeedWriter.js&rev=184.108.40.206&mark=404,406#397 I think this is unsafe. But, I cannot create a testcase since I don't know a way to execute this catch block. ------- Comment #69 From firstname.lastname@example.org 2008-09-03 05:14:55 PDT (-) Created an attachment (id=336641) [attachment 336713 [details] in this bug --dveditz] testcase 9 - handlers.doCommand() This works on fx220.127.116.11-candidate-build2 (2008082909). This uses bug 451680's XSS trick.
9 years ago
Mano, any update here?
Mano, have you had time to work on this? I'd hate to miss this for a third release in a row, especially since it's the last Firefox 2 release...
Mano, please attach a 1.8 patch for this. Code freeze is on Monday.
Created attachment 348427 [details] [diff] [review] patch See bug 388207, I didn't remove the element from subscribe.xhtml for the sake of backwards-compatibly.
Comment on attachment 348427 [details] [diff] [review] patch Approved for 18.104.22.168, a=dveditz for release-drivers
Can we get this landed asap? Code freeze was technically last night...
Checking in browser/components/feeds/src/FeedWriter.js; /cvsroot/mozilla/browser/components/feeds/src/FeedWriter.js,v <-- FeedWriter.js new revision: 22.214.171.124; previous revision: 126.96.36.199 done
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:188.8.131.52pre) Gecko/2008112503 BonEcho/184.108.40.206pre.
not an issue on 1.8.0