454102 - "Resolution" menu doesn't include "EXPIRED"

Status: VERIFIED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[benc]

I think this problem is from the newest upgrade to bmo, the resolution selector is missing "EXPIRED".

So, look at a bug that was expired, and it appears as "fixed", because it is the "menu defaults to top item because your backend value wasn't selected by the widget"...

Here's the source of my page:

      <span id="resolution_settings"><select name="resolution" id="resolution">
      <option value="FIXED">FIXED</option>
      <option value="INVALID">INVALID</option>
      <option value="WONTFIX">WONTFIX</option>
      <option value="DUPLICATE">DUPLICATE</option>
      <option value="WORKSFORME">WORKSFORME</option>
      <option value="INCOMPLETE">INCOMPLETE</option>
  </select></span>

Actually, I'm about to reopen this bug, so you'll have to search for another example.

Comment 1

[Dave Miller [:justdave]]

Oooh....  good catch.  The current value of the bug's resolution was never in that selector before, it was just in plain text at the top of the bug. :)

Here's the tricky part:  setting of the resolution to EXPIRED is restricted, and we've usually done it from the backend.  So the value should only show up in the select box if the bug is already set to it.

Comment 2

[Frédéric Buclin]

It would be easier to add EXPIRED as a valid resolution, and assume social rules to forbird users to use it except gerv (and those allowed to use it). It's a much better solution that another local hack.

Comment 3

[Gervase Markham [:gerv]]

Frederic: the problem with that is that we need to communicate this social control to all Bugzilla users. Adding it to the list if it's the actual value should be a one-liner.

[% "<option name="EXPIRED" selected>EXPIRED</option>" IF bug.resolution == "EXPIRED" %]

or similar.

Gerv

Comment 4

[benc]

I think that makes sense. The other solutions would be messier.

Comment 5

[Frédéric Buclin]

(In reply to comment #3)
> [% "<option name="EXPIRED" selected>EXPIRED</option>" IF bug.resolution ==
> "EXPIRED" %]

No, this won't work. Bugzilla will reject this resolution if it isn't a legal one, even if already set on a bug.

Comment 6

[Dave Miller [:justdave]]

(In reply to comment #5)
> No, this won't work. Bugzilla will reject this resolution if it isn't a legal
> one, even if already set on a bug.

But it *is* a legal resolution.  I suspect the code that excluded it from showing up in the "change resolution to" radio button got moved with the resolution select widget, without realizing that the widget needed to actually show the current value now instead of just offering something to change to.

Comment 7

[Dave Miller [:justdave]]

Attachment: Patch v1

bingo.

Comment 8

[Dave Miller [:justdave]]

Committing to: /var/www/html/bmo/3.2/
modified template/en/default/bug/knob.html.tmpl
Committed revision 6146.

Comment 9

[Dave Miller [:justdave]]

deployed to production.