454478 - No drag shadow displayed in month/multiweek view anymore

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.18pre) Gecko/2008090819 Sunbird/0.9

Steps to Reproduce:
1. Create an event and switch to Month or Multiweek view
2. Drag and drop the event to a different date
3. Observe the drag shadow

Actual Results:
No drag shadow is shown. There is no visual indication where the event will be dragged to.

Expected Results:
Drag shadow is displayed the same size as the normal event.

Regression range: Works in Sunbird 0.9pre (2008-09-07-20)
                  Fails in Sunbird 0.9pre (2008-09-08-19)

Checkins during regression range: http://tinyurl.com/6quh5d

Might be regressed by Bug 348009.

Comment 1

[Berend Cornelius]

Attachment: patch v. #1

I am sorry, this was really stupid! Yes this is a regression to Bug 348009. I paid so much attention to the freeze story that I did not notice that the dropShadows do not exist at all. Yet it was just a disturbing bracket that destroyed the patch. So  this should be an uncritical patch.
I further noticed that the dropshadows covered the whole daybox although due to their styling they should only have a fixed height of 1.2em. I fixed this, too, although this is a different story. To be sure about this I ask for ui-review.

Comment 2

[Stefan Sitter [:ssitter]]

Christian already commented on the size issue in Bug 432701. Adding dependency.

Comment 3

[Berend Cornelius]

Comment on attachment 337852 [details] [diff] [review]
patch v. #1

Removing request for ui-review as Christian already commented on this.
I suppose that the wrong size of the drop-shadows is a regression to  Bug 322979 .

Comment 4

[Stefan Sitter [:ssitter]]

Patch works fine for me on Windows XP.

Side note: Using a Trunk build the additional "}" results in a reported syntax error and the view is completely broken instead of just silently failing as in the Branch build.

Comment 5

[Berend Cornelius]

patch checked in on trunk, MOZILLA_1_8_BRANCH and SUNBIRD_0_9_BRANCH
->FIXED

Comment 6

[Stefan Sitter [:ssitter]]

Verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.18pre) Gecko/2008091120 Sunbird/0.9.