455454 - Clearing all cookies causes an error in url-classifier

Status: VERIFIED DUPLICATE of bug 447648

(Toolkit :: Safe Browsing, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

STR:

1. Clear all the cookies.
2. Watch the following error in the console:

Error: key is null
Source File: file:///c:/mozroot/hgmoz/obj-ff-opt/dist/bin/components/nsUrlClassifierLib.js
Line: 1173

This is observable when entering the private browsing mode as well.

The source of the error is that PROT_UrlCryptoKeyManager.unUrlSafe doesn't check its param |key| for being null, and it can indeed be null in two cases:

 * when being called by PROT_ListManager.rekey_ in response to the url-classifier-rekey-requested notification.
 * when being called by PROT_ListManager.cookieChanged_ in response to the cookie-changed notification.

The attached patch adds the null-ness check to unUrlSafe, and returns an empty string when key is null.

Comment 1

[Reed Loden [:reed]]

Uh, I don't think adding yourself to the contributors block for a one line change is appropriate here.

Comment 2

[(no longer active)]

Attachment: Patch (v1)

(In reply to comment #1)
> Uh, I don't think adding yourself to the contributors block for a one line
> change is appropriate here.

Sure, no big deal :-)

Comment 3

[John P Baker]

This looks like bug 447648 and related to bug 430074

Comment 4

[(no longer active)]

(In reply to comment #3)
> This looks like bug 447648 and related to bug 430074

This is actually a dupe of bug 447648.  I'll post my patch on that bug for review.

Comment 5

[Serge Gautherie (:sgautherie)]

V.Duplicate