Closed Bug 455807 Opened 15 years ago Closed 14 years ago

Copy toolkit NSIS macros into SeaMonkey installer code

Categories

(SeaMonkey :: Installer, defect)

Product:
SeaMonkey
Component:
Installer
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: mcsmurf, Assigned: mcsmurf)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch
8.12 KB, patch
standard8
: review+
Details | Diff | Splinter Review 
Installer build process complains about missing SUMMARY_MAKE_DEFAULT and SUMMARY_REBOOT_REQUIRED_INSTALL strings, not sure if we actually use those yet (shared toolkit/ NSIS files), adding anyway. See Windows nightly tinderbox for an example log file to see the warnings.
Attached patch Patch (obsolete) — — Splinter Review 
Assignee: installer → bugzilla
Status: NEW → ASSIGNED

        Attachment #339154 -
        Flags: review?(bugzilla)

        Attachment #339154 -
        Flags: review?(bugzilla)

        Attachment #339154 -
        Flags: review+

        Attachment #339154 -
        Flags: approval-seamonkey2.0a1+

    
    

    
  
Comment on attachment 339154 [details] [diff] [review]
Patch

I think it doesn't hurt to have these in, and as we're not string frozen, I think they are safe to land.
Blocks: 452928

    
    

    
  
Frank, I cc'd you on Bug 454130 which has info on how to fix this bug. Could you please copy the ini creation macros used by SeaMonkey from common.nsh and modify them as necessary to fix the warnings instead?

    
    

    
  
As soon as I have time, yes...currently I'm only fixing things for the alpha release. In a few weeks I should have more time again.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch
        — 
          — Splinter Review
      

    


  
This does the same changes to suite/ code as Bug 454130 did for Firefox. This is just copying code from common.nsh to installer.nsi.

        Attachment #339154 -
        Attachment is obsolete: true

        Attachment #342693 -
        Flags: review?

    
  

        Attachment #342693 -
        Flags: review? → review?(bugzilla)

    
    

    
  
Oh, I forgot: The unused strings from the earlier patch in this bug will probably be used by installer code as soon as Bug 453797 is fixed.

        Attachment #342693 -
        Flags: review?(bugzilla) → review+

    
    

    
  
Comment on attachment 342693 [details] [diff] [review]
Patch

Presumably we don't need the uninstaller.nsi changes?

I haven't tried this, but it looks fine.

    
  
Summary: Include missing strings into custom.properties → Copy toolkit NSIS macros into SeaMonkey installer code

    
    

    
  
Comment on attachment 342693 [details] [diff] [review]
Patch

Checked in, changeset 63c39e299c87

    
    

    
  
Looks fixed to me.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.