456300 - Disable location bar and search field while Tabsposé is showing

Status: RESOLVED FIXED

(Camino Graveyard :: Tabbed Browsing, defect)

Description

[Stuart Morgan]

Follow-up from bug 390909 that never got filed; those controls should be disable just as the rest of the toolbar is.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I think that we should also change or remove the URL in the location bar when we do this/are in Tabsposé view.

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

And probably remove the site icon, secure color, lock, and feed icon as well....

Comment 3

[Chris Lawson (gone)]

Why not just give the whole thing a disabled appearance?

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

More and more I think we need to treat this like Bookmarks, because what I see on the screen is not "Bug 461106 -  Focus lost after closing Tabsposé" and it's not a secure site; it's a bunch of tab thumbnails.

In fact, despite the fact we have all this validation code for particular buttons, maybe we should just hide the toolbar entirely, too.

Comment 5

[Stuart Morgan]

I had always assumed that the toolbar button would be a toggle though.

Comment 6

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

I don't follow; toggle what?

Comment 7

[Stuart Morgan]

Tabsposé. Click on, click off if you change your mind.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Oh, the Tabsposé toolbar button we don't have yet.  Yes, that makes sense ;)

Comment 9

[Stuart Morgan]

Attachment: disable editing

If we want to change the contents of the field (I'm not convinced yet), let's do it in a follow-up bug. Either way we need to prevent people from interacting with the field while in tab overview mode, so this part is necessary.

I didn't actually disable the whole field, because it looked odd to me. We might want to play with dimming the text and any icons, but that's less critical than the functionality.

Comment 10

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 349647 [details] [diff] [review]
disable editing

sr=pink

make sure nothing screwy happens when one or the other (or both) aren't part of the toolbar.

Comment 11

[Stuart Morgan]

Nope, no problems when they are removed/collapsed.

Landed on CVS trunk.