Closed Bug 456910 Opened 11 years ago Closed 11 years ago

Stop using exclusive locking in places

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED WONTFIX
mozilla1.9.1b1

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(1 file)

So, it turns out that using exclusive locking causes more fsyncs with the new sqlite (http://shawnwilsher.com/archives/175#comment-3134), so we should stop doing that.

The performance gains we got from it are likely not really there anymore (from drh), but I'm going to run some tests to see for sure.

Results will be posted in this bug.
Flags: blocking1.9.1?
The difference for a few queries I've tried is so small (order of magnitude is something like 10^-6 %) that I don't think it really matters.
Attached patch v1.0Splinter Review
Attachment #340355 - Flags: review?(dietrich)
Whiteboard: [has patch][needs review dietrich]
Attachment #340355 - Flags: review?(dietrich) → review+
Whiteboard: [has patch][needs review dietrich] → [has patch][has review][can land]
Pushed to mozilla-central:
http://hg.mozilla.org/mozilla-central/rev/ebafcda56f98
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Flags: in-litmus-
Flags: blocking1.9.1?
Resolution: --- → FIXED
Whiteboard: [has patch][has review][can land]
Comment on attachment 340355 [details] [diff] [review]
v1.0

If we want to take bug 449443 on branch, we'll need this as well.
Attachment #340355 - Flags: approval1.9.0.4?
Is this somehow related to what I mentioned in bug 452469 comment 51? Will this issue be gone with this check-in?
Well, it'll help, but we'll still have zombie firefox processes around
This will probably have to be backed out because of bug 457288
We had to back this out for bug 457288

This is likely going to be a WONTFIX
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
i've seen drh has fixed this ticket that is probably what we need
http://www.sqlite.org/cvstrac/chngview?cn=5745
maybe you can patch our 3.6.3 amalgamation with that and use a 3.6.3a version, if drh is not releasing 3.6.4 soon to address that
No longer blocks: 449443
Attachment #340355 - Flags: approval1.9.0.4?
We cannot do this without hurting Tp badly
Status: REOPENED → RESOLVED
Closed: 11 years ago11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.