Closed Bug 457288 Opened 18 years ago Closed 18 years ago

All platforms Tp regression and Vista Txul regression from bug 456910

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b1

People

(Reporter: dbaron, Assigned: sdwilsh)

References

Details

(Keywords: regression)

Last known good changeset (from qm-pmac-fast03, qm-pleopard-trunk01): http://hg.mozilla.org/mozilla-central/rev/4df87bc10bd7 First known bad changeset (from qm-pmac-fast03, qm-pleopard-trunk02): http://hg.mozilla.org/mozilla-central/rev/cdfaac3ff235
Lovely - we can't take the sqlite upgrade without that first changeset. Apparently I didn't run the right queries in my perf tests :/
qm-plinux-trunk01 reduces first known bad to http://hg.mozilla.org/mozilla-central/rev/3a436b085836 but that only eliminates the test-only checkin that I'd already eliminated. 2462db was not built by any talos boxes. ebafcd was not built by any tinderboxes that print the changeset to the waterfall.
So based on looking at the patches for the other two, we're pretty confident this was due to http://hg.mozilla.org/mozilla-central/rev/ebafcda56f98 sdwilsh says that backing out only that patch means we'll regress Ts a huge amount on Linux unless we also back out the sqlite upgrade. He suggests one possibility may be to ifdef for now, since the Tp regression on Linux was barely noticeable (although I don't trust our Linux Tp numbers), whereas it was worse on the other platforms. In other words, there are 4 possible paths forward: * leave everything in * back out above patch and a bunch of others, including the sqlite upgrade * back out only the above patch * ifdef the above patch so that it's Linux-only
Just in case I'm not around when the decision is made on what to do... If bug 456910 is backed out, we'll also need to backout the following bugs: bug 449443 (two changesets) bug 417037
On Vista, the Txul regression was actually even worse than the Tp regressions: http://graphs.mozilla.org/graph.html#show=787087,787109,787113,1431842&sel=1222283428,1222412080 but Txul regressions didn't show up on any other platforms; see, e.g., Windows XP: http://graphs.mozilla.org/graph.html#show=395002,395014,395042,912144,1431854&sel=1222283428,1222412080
Summary: Tp (pageload time) regression, morning of September 25, 2008 → All platforms Tp regression and Vista Txul regression from bug 456910
Fixed by backout.
Assignee: nobody → sdwilsh
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
So the Tp regression was fixed by the backout on Mac OS X (10.4 and 10.5), Windows XP, and probably Linux (where it was barely visible). In fact, times are better now than before the original change landed. However, neither Tp nor Txul has improved on Windows Vista. I'm stumped as to what's going on here.
You need to log in before you can comment on or make changes to this bug.