Closed Bug 457602 Opened 11 years ago Closed 11 years ago
_select() in search element breaks test framework
The search element contains a global function out_select(). That's not only exceptionally ugly, it also breaks the test framework by preventing it from loading the same page more than once on the same test run: Fatal error: Cannot redeclare out_select() (previously declared in /Users/fred/dev/addons/site/app/views/elements/search.thtml:178) in /Users/fred/dev/addons/site/app/views/elements/search.thtml on line 185 In addition, the CakePHP helper function $html->selectTag() is likely to already work as desired, so there's no need to reinvent the wheel.
Assignee: nobody → fwenzel
Severity: normal → major
Wil, would you be so nice to review this? Note: I had to wrap selectTag in a simpleSelectTag helper function because Cake's SelectTag insists on Yada/Yada notation for field names, which is undesired here.
Attachment #349652 - Flags: review?(clouserw)
Attachment #349652 - Flags: review?(clouserw) → review+
Thank you: r20195.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.