457602 - function out_select() in search element breaks test framework

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Administration, defect)

Description

[Fred Wenzel [:wenzel]]

The search element contains a global function out_select().

That's not only exceptionally ugly, it also breaks the test framework by preventing it from loading the same page more than once on the same test run:

Fatal error: Cannot redeclare out_select() (previously declared in /Users/fred/dev/addons/site/app/views/elements/search.thtml:178) in /Users/fred/dev/addons/site/app/views/elements/search.thtml on line 185

In addition, the CakePHP helper function $html->selectTag() is likely to already work as desired, so there's no need to reinvent the wheel.

Comment 1

[Fred Wenzel [:wenzel]]

Attachment: Wiping out_select() from the surface of the earth

Wil, would you be so nice to review this?

Note: I had to wrap selectTag in a simpleSelectTag helper function because Cake's SelectTag insists on Yada/Yada notation for field names, which is undesired here.

Comment 2

[Fred Wenzel [:wenzel]]

Thank you: r20195.