458660 - Remove Win16 support from Directory (LDAP) C SDK

Status: NEW

(Directory :: LDAP C SDK, defect)

Comment 1

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/comm-central/search?string=msdos&case=on&find=%2Fdirectory%2Fc-sdk%2F
Mark, is MS-DOS still supported? Or could you remove its support?

Comment 2

[Mark Smith [:mcs]]

I added Rich and Anton to the bug CC.

I don't think MSDOS has ever been supported inside the Mozilla C SDK code  We used to have code for 16-bit Windows, but I doubt anyone cares about that now.

Comment 3

[Rich Megginson]

Yes, let's get rid of the msdos code.

Comment 4

[Serge Gautherie (:sgautherie)]

http://mxr.mozilla.org/comm-central/find?string=%2Fdirectory%2Fc-sdk%2Fldap%2Fexamples%2F.*%5C.mak%24

/directory/c-sdk/ldap/examples/windows/winldap/LDAP16.MAK
/directory/c-sdk/ldap/examples/windows/winldap/winldap.mak

Should these two be removed.
Or replaced?
Or should the whole directory be removed?

/directory/c-sdk/ldap/examples/win32.mak

This one should stay, iiuc.

Comment 5

[Rich Megginson]

It looks like that directory is still valid - winldap.mak looks like a valid Visual C++ nmake Makefile.  I don't know if it works.  The LDAP16*.* files can definitely be removed.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> http://mxr.mozilla.org/comm-central/search?string=msdos&case=on&find=%2Fdirectory%2Fc-sdk%2F

http://mxr.mozilla.org/comm-central/search?string=msdos&case=on&find=%2Fldap%2Fsdks%2Fc-sdk%2F
"Found 24 matching lines in 15 files"


(In reply to comment #4)
> http://mxr.mozilla.org/comm-central/find?string=%2Fdirectory%2Fc-sdk%2Fldap%2Fexamples%2F.*%5C.mak%24

http://mxr.mozilla.org/comm-central/find?string=%2Fldap%2Fsdks%2Fc-sdk%2Fldap%2Fexamples%2F.*%5C.mak%24
{
/ldap/sdks/c-sdk/ldap/examples/windows/winldap/LDAP16.MAK
/ldap/sdks/c-sdk/ldap/examples/windows/winldap/winldap.mak
/ldap/sdks/c-sdk/ldap/examples/win32.mak
}

Comment 7

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Remove LDAP16.* [Checked in: Comment 8]

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 501301 [details] [diff] [review]
(Av1) Remove LDAP16.*
[Checked in: Comment 8]

http://hg.mozilla.org/projects/ldap-sdks/rev/b8553cb2163b

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

Serge, is this still a good first bug? I'm following up on older mentored/good first bugs. Thanks!

Comment 10

[Serge Gautherie (:sgautherie)]

(In reply to Liz Henry :lizzard from comment #9)
> Serge, is this still a good first bug?

I would answer "yes, in its (LDAP, make) context".

For example, I assume another easy step could be to remove
http://mxr.mozilla.org/comm-central/find?string=%2Fldap%2Fsdks%2Fc-sdk%2Fconfig%2Fwin.*\.mk
{{
/ldap/sdks/c-sdk/config/WIN32.mk <-- (Keep this one !)
/ldap/sdks/c-sdk/config/WIN95.mk
/ldap/sdks/c-sdk/config/WINNT.mk
/ldap/sdks/c-sdk/config/win16.mk
}}

Comment 11

[Serge Gautherie (:sgautherie)]

It looks like most was "fixed". (Related to Bug 1126607?)

Remaining (at least):
https://dxr.mozilla.org/comm-central/search?q=msdos.h+path:ldap/c-sdk/libraries/libldap/
"3 results from the comm-central tree"
and
https://dxr.mozilla.org/comm-central/search?q=win16+path:ldap/c-sdk/libraries/libldap/
"1 result from the comm-central tree"

Comment 12

[Christian]

I would be interested in working on this bug if its still an issue and unassigned.

Comment 13

[Takanori MATSUURA]

directory/c-sdk/ldap directory no longer exists in m-c.
The last update of ldap-sdks repository is Mon, 02 Oct 2017 17:44:02 +0200.
So it's time to close all the bugs in "LDAP C SDK" component (or "Directory" product) or move them to Graveyard.

Comment 14

[Mark Smith [:mcs]]

(In reply to Takanori MATSUURA from comment #13)

So it's time to close all the bugs in "LDAP C SDK" component (or "Directory" product) or move them to Graveyard.

I am not sure who makes the final call but I agree that one of these two suggestions should be implemented.