Closed
Bug 459286
Opened 16 years ago
Closed 16 years ago
gtk stock items for thunderbird menu items
Categories
(Thunderbird :: Mail Window Front End, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b1
People
(Reporter: mkmelin, Assigned: mkmelin)
References
()
Details
Attachments
(3 files, 1 obsolete file)
197.57 KB,
image/png
|
Details | |
25.83 KB,
patch
|
philor
:
review+
|
Details | Diff | Splinter Review |
2.80 KB,
patch
|
Details | Diff | Splinter Review |
Thunderbird should use menu item icons on linux - in some parts (like view source) it already does since we get them from toolkit. I suppose for some of the items, it's debatable what to do. Anyway, attaching a screenshot of what i've got.
Assignee | ||
Comment 1•16 years ago
|
||
This will/can look different, depending on your os theme of course.
Assignee | ||
Comment 2•16 years ago
|
||
Assignee | ||
Comment 3•16 years ago
|
||
Comment on attachment 342487 [details] [diff] [review] proposed fix For the composition window, some of the icons won't show until bug 459099 is fixed.
Attachment #342487 -
Flags: ui-review?(clarkbw)
Attachment #342487 -
Flags: review?(philringnalda)
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Comment 4•16 years ago
|
||
Comment on attachment 342487 [details] [diff] [review] proposed fix from the screenshot this looks great! \o/
Attachment #342487 -
Flags: ui-review?(clarkbw) → ui-review+
Comment 5•16 years ago
|
||
Randomly (because I'm like that): * 3pane has gtk-new for the New item, but not the Message item, compose has it for both * the dropdown for the Security button in compose should probably have the same icon that the View menu has for Message Security Info * why do we and Firefox both use key="key_openHelp" when the menuitem seems to have a perfectly good id? * pretty sure #context-printframe isn't going to match anything * the contextmenu print and printpreview icons are swapped
Assignee | ||
Comment 6•16 years ago
|
||
(In reply to comment #5) > * the dropdown for the Security button in compose should probably have the same > icon that the View menu has for Message Security Info If you mean compose Options | Security, then I don't think so. It's an info icon, and the other places it's used is for a menu item to view info. Otherwise good catches!
Comment 7•16 years ago
|
||
I meant compose - toolbar Security button dropdown arrow - View Security Info, our second path to open the same dialog as View - Message Security Info.
Assignee | ||
Comment 8•16 years ago
|
||
Oh that. Added. Re the help menu; I changed the id of the help menu to match that in toolkit, view source. (View source gets it's icons from toolkit.)
Attachment #342487 -
Attachment is obsolete: true
Attachment #343099 -
Flags: review?(philringnalda)
Attachment #342487 -
Flags: review?(philringnalda)
Comment 9•16 years ago
|
||
Comment on attachment 343099 [details] [diff] [review] proposed fix, v2 Pretty!
Attachment #343099 -
Flags: review?(philringnalda) → review+
Assignee | ||
Comment 10•16 years ago
|
||
changeset: 635:623bbaa8af7c http://hg.mozilla.org/comm-central/rev/623bbaa8af7c ->FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•16 years ago
|
||
Seems v2 didn't add the editorOverlay.css changeset: 636:73775e88392d http://hg.mozilla.org/comm-central/rev/73775e88392d Should fix the thinderbox red.
You need to log in
before you can comment on or make changes to this bug.
Description
•