Created attachment 342486 [details] screenshot of some of the more interesting bits Thunderbird should use menu item icons on linux - in some parts (like view source) it already does since we get them from toolkit. I suppose for some of the items, it's debatable what to do. Anyway, attaching a screenshot of what i've got.
This will/can look different, depending on your os theme of course.
Comment on attachment 342487 [details] [diff] [review] proposed fix For the composition window, some of the icons won't show until bug 459099 is fixed.
Comment on attachment 342487 [details] [diff] [review] proposed fix from the screenshot this looks great! \o/
Randomly (because I'm like that): * 3pane has gtk-new for the New item, but not the Message item, compose has it for both * the dropdown for the Security button in compose should probably have the same icon that the View menu has for Message Security Info * why do we and Firefox both use key="key_openHelp" when the menuitem seems to have a perfectly good id? * pretty sure #context-printframe isn't going to match anything * the contextmenu print and printpreview icons are swapped
(In reply to comment #5) > * the dropdown for the Security button in compose should probably have the same > icon that the View menu has for Message Security Info If you mean compose Options | Security, then I don't think so. It's an info icon, and the other places it's used is for a menu item to view info. Otherwise good catches!
I meant compose - toolbar Security button dropdown arrow - View Security Info, our second path to open the same dialog as View - Message Security Info.
Created attachment 343099 [details] [diff] [review] proposed fix, v2 Oh that. Added. Re the help menu; I changed the id of the help menu to match that in toolkit, view source. (View source gets it's icons from toolkit.)
Comment on attachment 343099 [details] [diff] [review] proposed fix, v2 Pretty!
changeset: 635:623bbaa8af7c http://hg.mozilla.org/comm-central/rev/623bbaa8af7c ->FIXED
Created attachment 343794 [details] [diff] [review] add the editoroverlay.css needed for proposed fix, v2 Seems v2 didn't add the editorOverlay.css changeset: 636:73775e88392d http://hg.mozilla.org/comm-central/rev/73775e88392d Should fix the thinderbox red.