Closed Bug 462185 Opened 13 years ago Closed 12 years ago

Don't include JavaScript stand-alone shell in distributions on Mac

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9.2a1

People

(Reporter: jimb, Assigned: philor)

References

Details

(Keywords: fixed1.9.1)

Attachments

(4 files)

The fix for bug 433083 builds the JavaScript stand-alone shell by default, and places it in dist/bin.  This executable shouldn't be included in OSX distributions.
Blocks: 433083
Tested with Tb/Mac and SM/Mac and Tb/Linux, and didn't seem to eat anything with Tb/Win. I was going to include Sunbird, but they seem to be a little warm right now.
Attachment #345671 - Flags: review?(bugzilla)
> I was going to include Sunbird, but they seem to be a little warm right now

That failure is regressed by Bug 433083 too and handled with Bug 462393.
Attachment #345671 - Flags: review?(bugzilla) → review+
Comment on attachment 345671 [details] [diff] [review]
Thunderbird and SeaMonkey [checked in]

Yep, that should work
Comment on attachment 345671 [details] [diff] [review]
Thunderbird and SeaMonkey [checked in]

http://hg.mozilla.org/comm-central/rev/3dd34f4ecbbe
Attachment #345671 - Attachment description: 2/3 of comm-central → Thunderbird and SeaMonkey [checked in]
Attachment #346126 - Flags: review?(gavin.sharp)
Attachment #346126 - Flags: review?(gavin.sharp) → review+
Comment on attachment 346126 [details] [diff] [review]
Firefox [checked in]

http://hg.mozilla.org/mozilla-central/rev/e2b0f076cba7
Attachment #346126 - Attachment description: Firefox → Firefox [checked in]
ted, bsmedberg: now that I'm halfway through doing this piecemeal, the same way that five out of six separate NO_PKG_FILES de-package xpcshell (and why does mac xulrunner depackage it, but not non-mac?), should I have done it just once in packager.mk's list instead, rather than continuing on to add it to xulrunner and mac xulrunner and calendar too?
Whoa, embarrassing newbie mistake there, asking a question using anything other than r? as a way to ask. The question was "should I have done it just once
in packager.mk's list instead, rather than continuing on to add it to xulrunner
and mac xulrunner and calendar too?"
Assignee: general → philringnalda
Status: NEW → ASSIGNED
Attachment #360432 - Flags: review?(ted.mielczarek)
Attachment #360432 - Flags: review?(benjamin)
OS: Linux → All
Hardware: x86 → All
Version: unspecified → Trunk
(In reply to comment #7)
> (and why doesmac xulrunner depackage it, but not non-mac?)

FWIW, this is probably because Windows/Linux use packages-static, so they don't package it in the first place.
Attachment #360432 - Flags: review?(ted.mielczarek)
Attachment #360432 - Flags: review?(benjamin)
Attachment #360432 - Flags: review+
They do? Which packages-static and how? I've never really looked at xulrunner packaging, but I'd sort of expect http://mxr.mozilla.org/mozilla-central/search?string=pkg_manifest&find=%2Fmozilla%2Fxulrunner%2F to have a result if xulrunner used a pkg_manifest.
Oh, oops. Dunno.
Attachment #360432 - Attachment description: Move removal to packager.mk → Move removal to packager.mk [checked in]
Comment on attachment 360432 [details] [diff] [review]
Move removal to packager.mk [checked in]

Drivers: dead simple, no net effect on the product since it just changes where we say not to package jsshell, but since the original way landed before 1.9.1 branched, it'll simplify things all around (okay, especially for comm-central, where we're building against both 1.9.1 and trunk without branching ourselves yet) to just have it done one way, no matter which version of toolkit.
Attachment #360432 - Flags: approval1.9.1?
Attachment #360432 - Flags: approval1.9.1? → approval1.9.1+
http://hg.mozilla.org/mozilla-central/rev/9e3be74281c8 the other day, and http://hg.mozilla.org/releases/mozilla-1.9.1/rev/1554f3ffe26e now, revert the comm-central change and I think I'll actually be done.
Keywords: fixed1.9.1
Oh, you put the js in, and you take the js out...

No need for us to unpkg it, since now toolkit's doing it for us, trunk and 1.9.1.
Attachment #361453 - Flags: review?(bugzilla)
Comment on attachment 361453 [details] [diff] [review]
Revert Thunderbird and SeaMonkey change

r=me by inspection
Attachment #361453 - Flags: review?(bugzilla) → review+
http://hg.mozilla.org/comm-central/rev/f89cb1d628ae and I'm getting bored with this bug, I think I'll close it.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Flags: in-testsuite-
You need to log in before you can comment on or make changes to this bug.