Closed Bug 462712 Opened 16 years ago Closed 16 years ago

Clean up and minimize NO_PKG_FILES

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

We have quite a variety of things stuck away in NO_PKG_FILES in mail/installer/Makefile.in - Windows executables, a smattering of test files, things which haven't existed for years, and the 122 byte savings of not packaging res/loading-image.gif (and getting the ugly red diamond as a result).

Since all our packaging on Windows uses packages-static, there's no point in anything Windows-specific in there, and once I finish bug 420391, we should cut it down to just things actually currently built on Mac that we don't want to ship.
Lest I forget, as I seem do within ten minutes of seeing it each time, our list gets the mostly-the-same list in toolkit/mozapps/installer/packager.mk appended onto it, so not only are we not packaging winEmbed.exe that we would never package anyway, we're not packaging it twice over.
No longer depends on: 420391
Depends on: 420391
Attached patch Fix v.1Splinter Review
This is on top of the patch in bug 453110 - mostly stuff that packager.mk is already taking care of for us, except for the last five, which are things that no longer exist.
Attachment #352971 - Flags: review?(bugzilla)
Status: NEW → ASSIGNED
Depends on: 453110
Attachment #352971 - Flags: review?(bugzilla) → review+
Comment on attachment 352971 [details] [diff] [review]
Fix v.1

Looks good, r=me by inspection.
http://hg.mozilla.org/comm-central/rev/dec0f8b8e686
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b2
You need to log in before you can comment on or make changes to this bug.