Closed Bug 462736 Opened 11 years ago Closed 11 years ago

add support for PARALLEL_DIRS to build system, ||ize suite/

Categories

(MailNews Core :: Build Config, defect, minor)

defect
Not set
minor

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(1 file)

i.e. port bug 461395 to comm-central
Attached patch Proposed patchSplinter Review
* Ports PARALLEL_DIRS changes
* Hoists makefiles into parent when dir only has subdirs
* Uses PARALLEL_DIRS when more than one subdir to make
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #345936 - Flags: review?(kairo)
Comment on attachment 345936 [details] [diff] [review]
Proposed patch

-DIRS = public src
+PARALLEL_DIRS = public src

You have to remember, that if there are ANY deps between dirs in PARALLEL_* we shouldn't use PARALLEL, as we can't be sure "public" idls are exported before "src" needs them... unless I am missing something entirely
Attachment #345936 - Flags: review-
(In reply to comment #2)
> (From update of attachment 345936 [details] [diff] [review])
> -DIRS = public src
> +PARALLEL_DIRS = public src
> 
> You have to remember, that if there are ANY deps between dirs in PARALLEL_* we
> shouldn't use PARALLEL, as we can't be sure "public" idls are exported before
> "src" needs them... unless I am missing something entirely
I think we only need the .h files which are exported in the export phase.
Comment on attachment 345936 [details] [diff] [review]
Proposed patch

I still need to test the patch, but please incorporate the bug 462730 patch into rules.mk when doing this.
Attachment #345936 - Flags: review- → review+
Comment on attachment 345936 [details] [diff] [review]
Proposed patch

I still haven't tested, but ted confirmed that export always finishes before libs is run
Comment on attachment 345936 [details] [diff] [review]
Proposed patch

r=me with incorporation of the mentioned followup into rules.mk
Attachment #345936 - Flags: review?(kairo) → review+
Whoops, forgot to mention that I pushed changeset 7d1219fe35d8 to comm-central.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Depends on: 464080
Depends on: 463846
You need to log in before you can comment on or make changes to this bug.