462863 - about:sessionrestore shouldn't display authentication requests for favicons

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect, P2)

Description

[Antonio Gomes (tonikitoo)]

Attachment: bug sshot.

1) Go to a website that requires a prompt login (user/passwd). 
e.g. https://projects.maemo.org/homepage was my testcase. I will post a generic testcase soon.
2) Log in.
3) Force browser to close abruptly (similate a crash).
4) Restart browser.
5) New session recover webpage shows up.

Actual outcome:

User/passwd dialog from testcase should not pop up until user mark that webpage to be recovered in the list.

Comment 1

[Simon Bünzli]

Attachment: get favicons over moz-anno:favicon:

Comment 3

[timeless]

Comment on attachment 346938 [details] [diff] [review]
get favicons over moz-anno:favicon:

nope. http auth can be challenged via http instead of https. i can setup a server if you need one.

Comment 4

[Simon Bünzli]

Comment on attachment 346938 [details] [diff] [review]
get favicons over moz-anno:favicon:

(In reply to comment #3)
> nope. http auth can be challenged via http instead of https.

So? Have you actually tried the patch?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As said by Simon this patch should also fix bug 466900. Because it is All/All this one should have the same flags.

Dietrich, do you have time to review the patch?

Comment 6

[Dietrich Ayala (:dietrich)]

Comment on attachment 346938 [details] [diff] [review]
get favicons over moz-anno:favicon:

r=me

Comment 7

[Dietrich Ayala (:dietrich)]

should set checkin-needed only after approval is granted

Comment 8

[Simon Bünzli]

(In reply to comment #7)
> should set checkin-needed only after approval is granted

Aren't we supposed to bake our patches on Trunk first (where no approval is needed)?

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #8)
> Aren't we supposed to bake our patches on Trunk first (where no approval is
> needed)?

Yes, and it would be great to have it in mozilla-central so we can check if it really fixes bug 466900.

Comment 11

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/5d7398ca49a9

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Asking for blocking1.9.1 because it will also fix bug 466900 for Fx3.1

Comment 13

[Dietrich Ayala (:dietrich)]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/acada1b76029

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20081224 Shiretoko/3.1b3pre ID:20081224020421

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20081222 Minefield/3.2a1pre ID:20081222020443

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081224 Shiretoko/3.1b3pre ID:20081224042714

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20081224 Minefield/3.2a1pre ID:20081224034752

Comment 16

[u279076]

in-litmus+
https://litmus.mozilla.org/show_test.cgi?id=7801