463213 - "All Tabs" panel with previews does not have a close button.

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Alice0775 White]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.4pre) Gecko/2008110205 Firefox/3.0.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081105 Minefield/3.1b2pre

When main window is small size, "All Tabs" panel covers the All Tabs Button.
So, I cannot toggle the panel by clicking the "All tabs button".

Reproducible: Always

Steps to Reproduce:
1.Open 3～ tabs
2.Resize main window to 500x500 (smaller than the "All Tabs" panel)
3.Click "All tabs button"
Actual Results:  
I can not close "All Tabs" panel by clicking "All tabs button".

Expected Results:  
A closing button of its own is necessary for "All Tabs" panel.

Comment 1

[Alice0775 White]

Attachment: Screenshot

Comment 2

[Dão Gottwald [:dao]]

You can really click anywhere to close the panel, doesn't have to be the "All Tabs" button.

Comment 3

[Percy Cabello]

The thing is the tab preview panel can be larger than the actual browser window so you can't "click anywhere" because it is all below the preview. Clicking on other apps or the desktop (at least in Vista) doesn't close the preview either.

Only way I see to close it is pressing the Esc key.

Comment 4

[WildcatRay]

(In reply to comment #2)
> You can really click anywhere to close the panel, doesn't have to be the "All
> Tabs" button.

Clicking anywhere outside the preview may not be obvious to many users. Isn't the standard convention to have a close button on windows whether they be an application's main window or a window inside a window like the tab preview?

Comment 5

[Damian Shaw [Quan]]

The Firefox window can be entirely encompassed by the the tab preview window
and pressing Esc isn't highly intuitive. It would make sense for there to be a
close button and it intuitive clicking anywhere outside it (even outside
Firefox) would close it, which doesn't appear to happen at the moment for me at least which I'll make a bug on in a second.

Comment 6

[Damian Shaw [Quan]]

I don't really think it's obvious or intuitive how to close the tab preview window when you don't want to make a selection. It's not always obvious which tab is the same as the one you're currently on and scrolling through the tab preview isn't always easy as the performance is pretty poor. I think it should be wanted, but maybe I'm missing something obvious.

Made bug 463220 for the other issue I mentioned in Comment #5

Comment 7

[Ryan Jones-Ward [:sciguyryan]]

How about auto-closing the panel if the user clicks anywhere outside it? That would be simple but as comment 4 notes - not really new user friendly, in which case something like a close button would be nice (maybe one that appears as you over over the panel or something?)

Comment 8

[Dão Gottwald [:dao]]

(In reply to comment #7)
> How about auto-closing the panel if the user clicks anywhere outside it?

See bug 463220.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

The panels should be click outside to close, but we should probably also still add a close button (for instance for platform parity on OS X with HUD windows).

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

This feature was removed from 3.1, so not blocking.

Comment 12

[Bill Gianopoulos [:WG9s]]

Well if clicking "anywhere" as suggested in comment #2 actually worked then it would be more obvious and would probably be sufficient.  You have to click somewhere outside the all tabs window.  If clicking inside the window but not on a specific preview dismissed it, that action would be the same as enough other applications that I would buy it as being obvious.  The fact that performing that does not dismiss the window is part of the issue.

Comment 13

[Dão Gottwald [:dao]]

Fixed by bug 465076.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed on 1.9.2 with builds on Windows and OS X like Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a2pre) Gecko/20090908 Namoroka/3.6a2pre (.NET CLR 3.5.30729) ID:20090908044437

Covered by https://litmus.mozilla.org/show_test.cgi?id=9162