463265 - Add first-run page content to Fashion Your Firefox collection

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Collections, defect)

Description

[David Rolnitzky]

Format should be similar to the Firefox first-run page in terms of layout.

Look and feel to be finalized shortly.

=============

[headline]
Thanks for trying the Fashion Your Fox collection!
Now your Firefox is tailored exactly to your needs and interests.

[column 1]
Your Add-Ons
You’ve successfully installed the following add-ons:

    * add-on #1
    * add-on #2
    * add-on #3
    * add-on #4

[column 2]
Getting Started
Your add-ons will appear in different places around the top, bottom or even the Tools menu of your browser. Some may open a new tab with useful information…just close it after you’ve had a look.

[column 3]
Need Help?
For more info about how Fashion Your Fox works, visit the FAQ. You can also search the main add-ons site for details on a specific add-on, or visit our support site for more about add-ons in general.

Comment 1

[David Rolnitzky]

There are 2 different approaches to this page, depending on whether or not the functionality which lists the add-ons in column 1 (noted above) is possible.

The first approach has a placeholder for this list.

The second approach takes out that column and has only column 2 and 3.

The files are too big to attach to bugzilla, so you can get them here:

Host: quasor.lunarpages.com
ID: tuffgu2
Password: triangle2

Approach 1: publc ftp/Fashion_Firefox/PSD/Fashion_Firefox_firstrun.psd
Approach 2 (without that first column): publc ftp/Fashion_Firefox/PSD/Fashion_Firefox_firstrun_2col.psd

Comment 2

[Fred Wenzel [:wenzel]]

I just committed r19617.

The "success" page we forward to now contains a very simple list of the add-on names that have been installed (that can be made more fancy as well as skinned appropriately).

The success page URL has now the style "/collections/success?i=3945,3590" with a comma separated list of add-on IDs that have been installed. The page persists after the restart, however it is overlayed under any first-run pages that add-ons in question may have.

CCing fligtar to see if that solution's fine with him (also note possible drawbacks, for example the fact that anyone can call that page with arbitrary IDs as parameters).

Comment 3

[Justin Scott [:fligtar]]

(In reply to comment #2)
> CCing fligtar to see if that solution's fine with him (also note possible
> drawbacks, for example the fact that anyone can call that page with arbitrary
> IDs as parameters).

This is totally up to David - I haven't been dealing with Collections stuff. I was only making suggestions on how it might be possible for Collections to have a pseduo first-run page by detecting if the restart has been completed.

Comment 4

[David Rolnitzky]

Fred -- does the first-run page (page after restart) also have the simple list of add-on names installed?  Or just the confirmation page?  That will impact the design a bit (from comment #1).

Doesn't seem like the drawback of anyone being able to call that page and make arbitrary ID's is a big risk here.

Assuming there's no other way to get the first-run page to appear first ahead of any first-run pages from add-ons, let's proceed with the above solution.

Comment 5

[Fred Wenzel [:wenzel]]

(In reply to comment #4)
> Fred -- does the first-run page (page after restart) also have the simple list
> of add-on names installed?  Or just the confirmation page?  That will impact
> the design a bit (from comment #1).

I haven't found a way to distinguish between the two: Thus, it's one and the same page, shown before (= success) and after the restart (= first-run).

Comment 6

[Fred Wenzel [:wenzel]]

I must correct myself, I just checked in r19627, writing and reading a cookie as per fligtar's suggestion. This allows us to distinguish between the content of the "success" and the "first-run" page, in spite of it being technically the same document.

The respectively irrelevant part of the page is being hidden with JavaScript.

Comment 7

[David Rolnitzky]

Attachment: Fashion Your Firefox first-run content mockup (psd file in comment below)

Comment 8

[Fred Wenzel [:wenzel]]

r19900.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of first-run page, post-fix

Is this OK?  It doesn't match the latest mock, but we already have the functionality of the left column in the needs-restart page...

Comment 10

[David Rolnitzky]

Since we already print the list before, I think this is ok if we go with the "2 column" approach.

Comment 11

[Fred Wenzel [:wenzel]]

(In reply to comment #9)
> Created an attachment (id=348277) [details]
> Screenshot of first-run page, post-fix
> 
> Is this OK?  It doesn't match the latest mock, but we already have the
> functionality of the left column in the needs-restart page...

The screenshot is wrong as a result of bug 444809. I will attach a screenshot of what people will actually see once the login requirement is gone in a second.

Comment 12

[Fred Wenzel [:wenzel]]

Attachment: Screenshot of first-run page as seen when no login is required

Here's the actual screenshot.

Comment 13

[Fred Wenzel [:wenzel]]

(In reply to comment #10)
> Since we already print the list before, I think this is ok if we go with the "2
> column" approach.

No, the success page (= pre-restart) does not contain a list of add-ons: I added a screenshot to the related bug: attachment 348306 [details] in bug 463272 comment 9.

Comment 14

[David Rolnitzky]

Fred, you've stated the order correctly in the bug, but the implementation still looks to be the opposite. It's giving the user the screenshot in attachment 348305 [details] (the post-restart first-run page) *before* the user restarts, and is not surfacing the confirmation page (attacment attachment 348306 [details]) at all that I can see.

Comment 15

[Fred Wenzel [:wenzel]]

You need to clear the cookie called "coll_restarted". If it's set, the first-run page will show.

Reason is: The first time the success page is shown, the cookie is set. User restarts the computer, the cookie is read and the first-run page is shown. At the same time, the cookie is marked for expiration at the end of the session, so the next time the user ends his browser, the cookie is gone again.

If they go to the page again after that, they'll see the "success" page again. Until then, there's no way to get the success page back.

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; tested installation with all add-ons on the list, and it still shows up.

Comment 17

[Fred Wenzel [:wenzel]]

Has been pushed live last night.