463553 - Add tabs to the Clear Recent History dialog box

Status: REOPENED

(Firefox :: General, enhancement, P4)

Description

[Alex Faaborg [:faaborg] (Firefox UX)]

The difference between browser history and session data exists primarily on an implementation level, and not necessarily inside of the user's mind (unless the user has been involved with Firefox development.)  I think we should add tabs to the Clear Recent History dialog, since clearing all information from a particular time period, but leaving certain tabs open from that time period is counter intuitive.

Another issues is how the Clear Recent History dialog relates to private browsing mode:

Something that I am worried about is that the user opens several embarrassing
tabs, and then opens up private browsing mode.  As the start page suggestions,
they clear their recent history using the Clear Recent History dialog.  Of
course, history isn't the same thing as active tabs (in the implementation
model, but not the user's mental model), so these embarrassing tabs are
persisted in the previous session.  The user eventually closes down Firefox,
and leaves.  The next person to load Firefox will see the sensitive tabs, even
though the user thought they were taking every action they needed to in order
to cover their tracks.

Comment 1

[Simon Bünzli]

(In reply to comment #0)
> since clearing all information from a particular time period, but leaving
> certain tabs open from that time period is counter intuitive.

That's actually a bug (see bug 463188 comment #7). All data saved by SessionStore should be discarded when clearing browser History. We currently fail to do that in the case where you've entered Private Browsing mode. No need for new UI.

Comment 2

[Simon Bünzli]

This bug as it stands was FIXED in bug 463188.

Comment 3

[Alex Faaborg [:faaborg] (Firefox UX)]

>All data saved by
>SessionStore should be discarded when clearing browser History. We currently
>fail to do that in the case where you've entered Private Browsing mode. No need
>for new UI.

A few questions just to make sure I understand how this currently works:

-Can we clear based on the specific time period that the user specifies in the Clear Recent History Dialog?

-Does this include currently open tabs, recently closed tabs, both?

The intended feature was to clear any tabs (open or closed) that exist from new navigation events (open a new tab, enter a new URL In the location bar, click on link from external app) during the selected time period.

Comment 4

[Alex Faaborg [:faaborg] (Firefox UX)]

Simon, a few questions in the last comment ^^

Comment 5

[Simon Bünzli]

(In reply to comment #3)
> -Can we clear based on the specific time period that the user specifies in the
> Clear Recent History Dialog?

No. This is currently all-or-nothing.

> -Does this include currently open tabs, recently closed tabs, both?

This includes anything we're tracking.

> The intended feature was to clear any tabs (open or closed) that exist from
> new navigation events

Right, I misread your bug description as to only affecting the remembered tabs in private browsing mode. Note the issues raised in bug 464417.

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

>No. This is currently all-or-nothing.

Ok, resolving this bug would need to involve clearing information based on the specified time range.

Comment 7

[Alfred Kayser]

Can be marked FIXED or DUP by bug 480169 ??

Comment 8

[(no longer active)]

(In reply to comment #7)
> Can be marked FIXED or DUP by bug 480169 ??

No, that bug did not add "tabs" to the list of selections in the CRH dialog.

Comment 9

[Michael T]

I have an issue with the fact that when I remove certain pages (manually) from my history they remain accessible from the "Recently closed tabs" menu.  Does that fall under this particular bug?

Comment 10

[Michael T]

No, bug 493124 seems to be what I was looking for.