Closed Bug 467050 Opened 14 years ago Closed 14 years ago

add config.mk to the GLOBAL_DEPS list as well

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b3

People

(Reporter: Callek, Assigned: Callek)

References

Details

(Keywords: fixed1.9.1)

Attachments

(1 file, 1 obsolete file)

Add config.mk (v2) [Checkin: Comment 4 & 6]
1.06 KB, patch
ted
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
from Bug 463824 c#0

Should we add $(topsrcdir)/config/config.mk to the list as well?

bsmedberg, ted; confirm if "yes", wontfix if "no".

I'll attach a patch within a few days if not wontfixed by then anyway.
Attached patch Add config.mk (obsolete) — — Splinter Review 
I created the patch earlier than I expected so I could fire off a try-build for someone ;-)
Assignee: nobody → bugspam.Callek
Attachment #350426 - Flags: review?(ted.mielczarek)
Comment on attachment 350426 [details] [diff] [review]
Add config.mk

actually I need to settle on $(DEPTH) vs. $(topsrcdir) and I think I'll go with DEPTH...
Attachment #350426 - Flags: review?(ted.mielczarek) → review-
...also include js/src/... change
Attachment #350426 - Attachment is obsolete: true
Attachment #350429 - Flags: review?(ted.mielczarek)
Attachment #350429 - Flags: review?(ted.mielczarek) → review+
Status: UNCONFIRMED → NEW
Ever confirmed: true
pushed as: http://hg.mozilla.org/mozilla-central/rev/43ed1b0f68eb
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Attachment #350429 - Flags: approval1.9.1?
Comment on attachment 350429 [details] [diff] [review]
Add config.mk (v2)
[Checkin: Comment 4 & 6]

a191=beltzner
Attachment #350429 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 350429 [details] [diff] [review]
Add config.mk (v2)
[Checkin: Comment 4 & 6]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/bf625f8ef7b2
Attachment #350429 - Attachment description: Add config.mk (v2) → Add config.mk (v2) [Checkin: Comment 6]
Attachment #350429 - Attachment description: Add config.mk (v2) [Checkin: Comment 6] → Add config.mk (v2) [Checkin: Comment 4 & 6]
Flags: in-testsuite-
Keywords: fixed1.9.1
Target Milestone: --- → mozilla1.9.1b3
(In reply to comment #2)
> actually I need to settle on $(DEPTH) vs. $(topsrcdir) and I think I'll go with DEPTH...
DEPTH is the OBJDIR!
Depends on: 495224
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.