464162 - Apache does not accept IPv6 addresses with a scope id in the Host: header

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Masahiro YAMADA]

See https://issues.apache.org/bugzilla/show_bug.cgi?id=35122
-- 
When entering a scoped IPv6 address in Firefox, that same address is put in the HTTP Host: header.
But Apache rejects it with a 400 Bad Request and logs "Client sent malformed Host header" in the error log.

Comment 1

[Masahiro YAMADA]

I think , we should remove scope id before adding IPv6 address to Host: header.

http://mxr.mozilla.org/firefox/source/netwerk/protocol/http/src/nsHttpChannel.cpp?rev=1.334#213

Comment 2

[Masahiro YAMADA]

Attachment: Patch rev1.0 (for Trunk)

Sorry, I don't have IPv6 test environment. Please test this patch.

Comment 3

[Masahiro YAMADA]

Attachment: Patch rev.1.01

Patch rev.1.0 removes character before "%".
"-1" in parameter of Left() is not needed.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 348559 [details] [diff] [review]
Patch rev.1.01

+        if (scopeIdPos < 0)

should be:
  if (scopeIdPos == kNotFound)

+            nsCAutoString ipv6Addr;
+            host.Left(ipv6Addr,scopeIdPos);
+            hostLine.Append(ipv6Addr);

should be:
  hostLine.Append(Substring(host, 0, scopeIdPos));

thanks for the patch!

Comment 6

[Christian :Biesinger (don't email me, ping me on IRC)]

(note that I haven't tested this yet, I can do that tomorrow)

Comment 7

[Masahiro YAMADA]

Attachment: Patch rev.1.02

Comment 8

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 348753 [details] [diff] [review]
Patch rev.1.02

I tested this now and it does work.


You didn't make the kNotFound change.

Also, you should remove the brackets here for consistency now:
+        else if (scopeIdPos > 0) {
+            hostLine.Append(Substring(host, 0, scopeIdPos));
+        }

Comment 9

[Masahiro YAMADA]

Attachment: Patch Rev.1.03

Sorry for spam.

Comment 10

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 348754 [details] [diff] [review]
Patch Rev.1.03

can you please fix my other comment as well

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 348754 [details] [diff] [review]
Patch Rev.1.03

Please ask for sr once this has r=  (though I'd think biesi can r+sr this one).

Comment 12

[Masahiro YAMADA]

Attachment: Patch Rev.1.04 [Checkin: Comment 14]

(In reply to comment #10)
> (From update of attachment 348754 [details] [diff] [review])
> can you please fix my other comment as well

Oops, removing blacket is missing.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348758 [details] [diff] [review]
Patch Rev.1.04
[Checkin: Comment 14]

a191=beltzner

Comment 14

[Serge Gautherie (:sgautherie)]

Comment on attachment 348758 [details] [diff] [review]
Patch Rev.1.04
[Checkin: Comment 14]

http://hg.mozilla.org/mozilla-central/rev/bb80e727c531

Comment 15

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f9b9392580e2

Comment 16

[Daniel Veditz [:dveditz]]

Comment on attachment 348758 [details] [diff] [review]
Patch Rev.1.04
[Checkin: Comment 14]

This fix is not in the scope of our maintenance releases.