Closed
Bug 464310
Opened 17 years ago
Closed 17 years ago
Junk button not working on message reader header view.
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b1
People
(Reporter: standard8, Assigned: Bienvenu)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1017 bytes,
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
The Junk button in the message reader header view is currently not being shown by default in trunk builds.
For it to be shown, you have to mark the message as junk, at which point it is shown constantly.
Flags: blocking-thunderbird3+
|
||
Updated•17 years ago
|
Whiteboard: [fixed by 456818]
|
|
||
Updated•17 years ago
|
Target Milestone: Thunderbird 3.0b1 → Thunderbird 3.0b2
|
|
||
Updated•17 years ago
|
Assignee: dmose → bienvenu
|
|
||
Updated•17 years ago
|
Target Milestone: Thunderbird 3.0b2 → Thunderbird 3.0b1
|
Assignee | |
Comment 2•17 years ago
|
||
I think this was accidentally broken in the otherwise really nice cleanup work that happened recently ;-)
Attachment #349260 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•17 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [fixed by 456818] → [has patch for review]
|
||
Comment 3•17 years ago
|
||
"// we do this" is one awesome code comment ;)
|
|
Assignee | |
Comment 4•17 years ago
|
||
Comment on attachment 349260 [details] [diff] [review]
proposed fix
heh, thoughtus interruptus - I'll remove that. The thought was going to be a lot more profound, but then I changed the variable name, and the comment became unnecessary.
|
||
Updated•17 years ago
|
Blocks: 462681
Keywords: regression
|
|
||
Comment 5•17 years ago
|
||
Comment on attachment 349260 [details] [diff] [review]
proposed fix
Looks good, thx! r=mkmelin
(with the // we do this comment removed)
Attachment #349260 -
Flags: review?(mkmelin+mozilla) → review+
|
|
||
Updated•17 years ago
|
Whiteboard: [has patch for review] → [ready to land]
|
|
Assignee | |
Comment 6•17 years ago
|
||
fix checked, w/ comment reluctantly removed :-)
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [ready to land]
You need to log in
before you can comment on or make changes to this bug.
Description
•