464714 - won't cross folders for next unread item

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Cory Albrecht]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.3) Gecko/2008092417 Firefox/3.0.3 (.NET CLR 3.5.30729)
Build Identifier: 3.0b1pre 20081113031301

Regardless of the setting of mailnews.nav_crosses_folders, Shredder 3.0b1pre 20081113031301 will not advance to the next unread item in a different folder

Reproducible: Always

Steps to Reproduce:
1. start shredder 3.0b1pre 20081113031301
3. Go into advanced config and set mailnews.nav_crosses_folders to 0 or 1
2. make sure you have unread items in different folders
3. view an item in folder where there are no unread items.
3. use space (at bottom of message), N or Menu->Go->Next->Unread Message
4. if setting is 1, chose yes to go to next unread
Actual Results:  
Shredder does nothing, just stays in current folder displaying the current item.

Expected Results:  
If mailnews.nav_crosses_folders is set to 0 or 1, when space (at bottom of message), N or Menu->Go->Next->Unread Message are done and the are no more unread items in teh current folder, Shredder should go to the next folder where there are unread items and display the first unread

Comment 1

[Richard Marti (:Paenglab)]

I can confirm this. After type space, N or thrue the menu and I select then the next folder with unread messages, Shredder jumps directly to the unread message.

I see in the error console no error.

Comment 2

[Wayne Mery (:wsmwk)]

fails also in news

Comment 3

[Joey Minta]

I can work on this later this evening, if someone doesn't get to it first.

Comment 4

[Joey Minta]

Attachment: [checked in] part of the fix

This is another one of those really annoying cases where the shared code assumes that forked code will provide a particular function. I forgot how often mailnews/ has this backwards dependency.

Note that messages aren't quite loading correctly here for me, but they at least get partly loaded.

Comment 5

[Joey Minta]

Attachment: stop hiding errors

This is why no one could report any errors.

Comment 6

[Ronald Killmer]

Thanks! I just updated my Windows build and confirmed the OP's query in mozilla.support.thunderbird

Will this also fix the collapsed Folder Pane which has violated my Pref setting?  If not then a separate bug seems in order.

Comment 7

[Joey Minta]

Comment on attachment 347994 [details] [diff] [review]
[checked in] part of the fix

I've checked in this part, which at least gets the prompts going again, and selects the folder. Please let me know if you continue to have other problems with the navigation.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

What's the current user-experience, given the partial fix that has landed since this was filed?

Comment 9

[Joey Minta]

I was seeing weird behavior where the header would load but the body wouldn't. That may be particular to my build though. It'd be helpful if the reporter and other nightly users could report tomorrow.

Comment 10

[David :Bienvenu]

Comment on attachment 348017 [details] [diff] [review]
stop hiding errors

but you don't need the braces...next unread crossing folders and selecting messages works for me, except for the case where the next folder with unread is a cross-folder saved search.

Comment 11

[Joey Minta]

I checked in the second patch as rev 46a840a625b1. I'm marking this fixed for now. If anyone continues to see problems with cross-folder navigation, please reopen.

Comment 12

[Ronald Killmer]

The OP and I will be rechecking on Saturday, 11/15/2008.

Thank You for working on this.

Comment 14

[Cory Albrecht]

Works now in in Shredder 3.0b1pre 20081114033300. Thanks!

Comment 15

[Joey Minta]

Attachment: mozmill test

Mozmill test to make sure we don't regress this again.

Comment 16

[Ronald Killmer]

WooHoo. It's nice to have the old familiar behavior back.  Thank You Joey!

Comment 17

[Mark Banner (:standard8)]

Comment on attachment 348307 [details] [diff] [review]
mozmill test

Please make the file location mail/tests/mozmill. r=me with that.