465293 - Edit bookmark

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Bookmarks, enhancement)

Comment 1

[Christian Sejersen]

It should be possible to edit a bookmark (and bookmark folder)

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

We do allow editing a bookmark using the "star" button. Do you mean editing a bookmark using a different trigger?

Currently, we don't support folders. See bug 456482. Is this a dupe?

Comment 3

[Christian Sejersen]

Currently you can only edit a bookmark if you actually are on that page. That seems a bit cumbersome :)

So there should be an option to actually edit a bookmark when you are in the "bookmark app". Same thing for folders. 

So I don't think this is a dupe.

Comment 4

[Christian Sejersen]

Another thing is you can't edit the URL in the current "star button invocation"

Comment 6

[Neil Deakin]

Attachment: edit bookmarks

Adds Edit buttons into the bookmark list for editing of bookmarks. Also updates the Star button to edit only the current page, and allows editing of the url.

Comment 7

[Stuart Parmenter]

if you're going to rename urlbar, shouldn't it be to bookmarks.xml or something?

Comment 8

[:Gavin Sharp [email: [e-mail]]]

It also contains URL bar stuff...

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 352406 [details] [diff] [review]
edit bookmarks

The only nits I have are related to the use of "BrowserUI." from inside BrowserUI methods. Using "this." seems more conventional.

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

At some point, it might be nice to refactor out the bookmark list behavior into a helper class. But that might just be my personal bias.

Comment 11

[Stuart Parmenter]

style nit:
+  stopEditBookmark : function()
+  {

please put the { on the same line, like the rest of the file

Comment 12

[Aakash Desai [:aakashd]]

it's possible to edit a bookmark on builds:

Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090818 Fennec/1.0a3pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre