466717 - avoid using a <panel> as our autocomplete popup

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[:Gavin Sharp [email: [e-mail]]]

We can reimplement nsIAutocompletePopup without an actual <panel>, to avoid using an extra native window.

Comment 1

[Stuart Parmenter]

hurray

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

This implements basic autocomplete functionality. Text highlighting isn't implemented yet, but wanted to get this reviewed first and implement the text selection next.

Current Issues:
- hardcoded number of entries (7)
- no favicon/star icon styling, or text highlighting

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 352023 [details] [diff] [review]
patch

>diff --git a/chrome/content/browser-ui.js b/chrome/content/browser-ui.js
>+    var toolbarH = document.getElementById("toolbar-main").boxObject.height;
>     var popup = document.getElementById("popup_autocomplete");
>-    popup.height = containerH - toolbarH;
>+    popup.height = window.innerHeight - toolbarH;

can you add the popup.width here too?


>diff --git a/chrome/content/browser.xul b/chrome/content/browser.xul

>+    <vbox id="popup_autocomplete" style="-moz-stack-sizing: ignore;" width="800" height="420" top="60" left="0" constraint="ignore-x,vp-relative">
>+      <hbox id="autocomplete_navbuttons" align="center" flex="1"
>+            oncommand="BrowserUI.doButtonSearch(event.target);">
>+        <image class="tool-search"/>
>+      </hbox>
>+    </vbox>

Remove the hardcoded width and height? We set those in BrowserUI._sizeControls

Comment 4

[:Gavin Sharp [email: [e-mail]]]

With those comments addressed:
https://hg.mozilla.org/mobile-browser/rev/2be90c4fb7b6

Filed bug 468657 for match highlighting.

Comment 5

[Aakash Desai [:aakashd]]

verified FIXED on builds:
Mozilla/5.0 (Windows; U; WindowsCE 5.2; en-US; rv:1.9.3a1pre) Gecko/20090818 Fennec/1.0a3pre

and

Mozilla/5.0 (X11; U; Linux armv6l; en-US; rv:1.9.3a1pre) Gecko/20090821
Fennec/1.0b3pre

and

Mozilla/5.0 (Macintosh; U; Intel Mac OSX 10.5; en-US; rv:1.9.2a2pre)
Gecko/20090808 Fennec/1.0b3pre