Closed Bug 466740 Opened 16 years ago Closed 8 years ago

Find -> Highlight All uses magenta (ugly purple) as a highlight color

Categories

(Firefox :: Theme, defect)

defect
Not set
normal
Points:
2

Tracking

()

RESOLVED FIXED

People

(Reporter: Dolske, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: polish, Whiteboard: [fixed by bug 384458])

Found when looking at 426731.

Command-F to bring up a find bar, enter a term, click Hilight All. This shows all the found strings in the page with a bright magenta/purple color. It should really be yellow, or whatever 426731 decides on. Oddly, Faaborg gets yellow on his nightly, so it's not clear WTF is happening here.
This was changed by bug 451204.
Target Milestone: Firefox 3.1 → Firefox 3.5
Depends on: 776708
Blocks: 565552
No longer depends on: 776708
Target Milestone: Firefox 3.5 → ---
Related: bug 517773
"Hilight all" for various applications on Windows 7:

Hilight all:
IE9: #ffff00 (strong yellow)
Chrome: #ffff96 (pale yellow)
Word 2010: #ffdc00 (orangey-yellow)
Visual Studio 2012: #f6b94d (peachy)
Firefox 20: (saturated magenta)

Current find result:
IE9: text selection (opaque white on blue)
Chrome: #ff9632 (redish-peachy)
Word 2010: text selection (transparent blue, mixes with hilight)
Visual Studio 2010: #a8ac94 (grey)
Firefox 20: (bright green)
OS: Mac OS X → All
Hardware: x86 → All
Summary: Find -> Hilight All uses magenta (ugly purple) as a highlight color → Find -> Highlight All uses magenta (ugly purple) as a highlight color
Can this be assigned to me? Also what is a prefered color to use instead of the current one?
Bug 451204 comment 19 seems to be the most comprehensive in listing the reasons why the current color was chosen over other possibilities (although that whole bug is worth reading as was mentioned before).

In addition, you can set the highlight color through an add-on: bug 517773 comment 4

And also, I believe bug 384458 should be considered here as well, as its choice of highlights color could be of influence here, or depending on its outcome, could even render this discussion irrelevant.
Whiteboard: [feature] p=0
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Whiteboard: [feature] p=0 → p=0
Points: --- → 2
Whiteboard: p=0
Depends on: 384458
I can confirm that this was fixed by bug 384458.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 384458]
The highlight now dims the whole page and cuts out sections that match the search term.
You need to log in before you can comment on or make changes to this bug.