Created attachment 350314 [details] [diff] [review] Patch v1 Clicking on the "Today" button in the minimonth doesn't refresh the calendar view. It should refresh because another day is selected in minimonth. If you select a day directly per click, the calendar view is refreshed. The issue was reported to me by Ludovic, and he also created the patch. First requesting just ui-review from Christian.
As far as I can remember this was done on purpose. The behavior is similar to the < and > buttons in the minimonth that don't change the views but only the minimonth itself. Only a selection of a specific date in the minimonth will change the view but only if the calendar view is displayed. For example selecting a specific date in the minimonth in the Today Pane needs a different action.
Stefan, you're right about this but when you click on the "Go to Today" button, it does select the current day. If it does select, it should also change the view.
Comment on attachment 350314 [details] [diff] [review] Patch v1 Makes sense & would save one click. ui+
Comment on attachment 350314 [details] [diff] [review] Patch v1 >+ oncommand="var d = new Date(); this.kMinimonth.selectDate(d); >+ this.kMinimonth.dayClicked(this.kMinimonth.getBoxForDate(d));" Aside from the fact that the oncommand attribute is now duplicate, I'd rather see this fixed in the minimonth binding if possible. I guess I can live without that for now though. r=philipp with first oncommand attribute removed.
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/ac5088aa887e> -> FIXED
Error: this.kMinimonth.dayClicked is not a function Source File: chrome://messenger/content/messenger.xul Line: 1
Ludovic, can you provide a patch to fix the error and make the feature work? Otherwise I'd recommend to back out the patch.
Backed out from comm-central <http://hg.mozilla.org/comm-central/rev/2e3bd45d1468>
Created attachment 359101 [details] [diff] [review] Proposed fix v2
Comment on attachment 359101 [details] [diff] [review] Proposed fix v2 At first this solution looked very elegant. To make it even better you could also directly assign the commmand "calendar_go_to_today_command". But I am sorry to deny the review: The minimonth is not necessarily linked to the calendar views as it would with your solution. For example you can configure a minimonth in the today-pany above the agenda-listbox and control the date of the agenda-listbox with it without having any impact on the calendar-views.
(In reply to comment #11) The patch refreshes calendar views when go to today is clicked on the minimonth above agenda-listbox. Is this not wanted ? If it is wanted + select day -> refresh the calendar views than the last part is another bug. ? I've just noticed that there is a bigger problem (not related to the patch) with the go to today button and minimonth + agenda-listbox - the day in agenda-listbox is not refreshed to display events for today.
Please reply because I'm not sure what is wanted / what are the side effects of the proposed fix from your side.
In our application we have several minimonths and we do not want each of them to set the calendar-views to "today". Only the minimonth with the id "calMinimonth" is supposed to do this.
>The patch refreshes calendar views when go to today is clicked on the minimonth >above agenda-listbox. This is not the desired behaviour of that minimonth. I guess my explanation for this in commment #11 was not unambiguous.
I think this bug is related to what I found here: https://bugzilla.mozilla.org/show_bug.cgi?id=476312 If someone agrees, I think it may be appropriate to list this bug as a dependency, or else create a new one that encompasses the entire class of these bugs. I don't think this is a minor bug - I think the root cause of this bug, namely the decoupling of information displayed in the Today pane with the actual task/event information is responsible for several open or unconfirmed bugs. I would appreciate a developer looking at my bug (and my comments) and offering their insight - if it turns out I'm completely wrong, I'm happy to admit it. But I think this points to a systemic flaw in the coupling of displayed information (within the Today Pane) to the actual object information.
(In reply to comment #16) No. Currently it works as specified. The patch above that wanted to change the current the behavior introduced the error in comment #6 and therefore was backed out. There is no relation to bug 476312.
Created attachment 361540 [details] [diff] [review] Proposed fix v3 Fixes this bug + <quote> I've just noticed that there is a bigger problem (not related to the patch) with the go to today button and minimonth + agenda-listbox - the day in agenda-listbox is not refreshed to display events for today. </quote> Please test for regressions ;)
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/3096bf930f58> -> FIXED