Closed Bug 467174 Opened 14 years ago Closed 14 years ago

Add preferences options for popup and missing plugin infobars

Categories

(SeaMonkey :: Preferences, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
seamonkey2.0a3

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

References

Details

Attachments

(1 file, 3 obsolete files)

As per discussion in m.d.seamonkey:

Add checkboxes to Privacy & Security > Popup Windows and Advanced > Scripts & Plugins respectively that change the corresponding already existing prefs, namely privacy.popups.showBrowserMessage and plugins.hide_infobar_for_missing_plugin. For the latter the middle part of the pref pane ("Allow scripts to:") could be reduced in size.
Component: General → Preferences
QA Contact: general → prefs
Attached patch Popups part (obsolete) — Splinter Review
Attached patch patch for both (obsolete) — Splinter Review
Chose to use different labels, now all in one patch
Assignee: nobody → jh
Attachment #350649 - Attachment is obsolete: true
Attachment #350653 - Flags: review?(neil)
Attachment #350653 - Flags: review?(neil) → review-
Comment on attachment 350653 [details] [diff] [review]
patch for both

>+    
Nit: whitespace

>+      <hbox>
pref-popups likes to wrap its checkboxes in hboxes but pref-scripts doesn't.

>+        <checkbox id="displayPluginsInfoBar"
>+                  label="&displayPluginsInfoBar.label;"
>+                  accesskey="&displayPluginsInfoBar.accesskey;"
>+                  preference="plugins.hide_infobar_for_missing_plugin"/>
I don't think that this checkbox really fits in this group.

>+<!ENTITY displayPopupsInfoBar.label     "Display an info bar at the top of the content area">
Aren't we supposed to call this a notification bar, rather than an info bar?
Also, this is pref-popups, no need to repeat yourself.

>+<!ENTITY displayPopupsInfoBar.accesskey "I">
I is a very poor choice of accesskey. (I've always wanted to say "I is" ;-)

>+<!ENTITY displayPluginsInfoBar.label     "Display an info bar at the top of the content area">
Except that this label doesn't explain why the notification might occur.

>\ No newline at end of file
Oops ;-)
Attached patch patch v2 (obsolete) — Splinter Review
Nits addressed. Instead of changing the groupbox captions or introducing yet another groupbox I chose to make the Scripts & Plugins groupboxes look more similar (caption, checkboxes, separator, description, checkboxes).
Attachment #350653 - Attachment is obsolete: true
Attachment #350873 - Flags: review?(neil)
Comment on attachment 350873 [details] [diff] [review]
patch v2

>+      <description id="whenAddlPluginsRequired">&whenAddlPluginsRequired.description;</description>
>+      <checkbox id="displayPluginsNotificationBar"
Nit: blank line between these two please.
I don't really like the Addl there so just call that one whenPluginsRequired and you might as well use displayNotification without the Bar (in all files) so that you can align the text up in the .dtd files ;-)
Attachment #350873 - Flags: review?(neil) → review+
nits addressed, carrying over r+
Attachment #350873 - Attachment is obsolete: true
Attachment #351008 - Flags: review+
How about filing a bug for updating our help files? ;-)
Attachment #351008 - Flags: superreview?(neil)
Status: NEW → ASSIGNED
Attachment #351008 - Flags: superreview?(neil) → superreview+
Thanks Neil.

To whoever checks this in: don't get confused, r+sr=Neil of course.

(In reply to comment #7)
> How about filing a bug for updating our help files? ;-)

Filed bug 467674.
Keywords: checkin-needed
Comment on attachment 351008 [details] [diff] [review]
final patch
[Checkin: Comment 9]

http://hg.mozilla.org/comm-central/rev/98e20aa2f22e
Attachment #351008 - Attachment description: final patch → final patch [Checkin: Comment 9]
Blocks: 467674
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Summary: [RFE] Add preferences options for popup and missing plugin infobars → Add preferences options for popup and missing plugin infobars
Target Milestone: --- → seamonkey2.0a3
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20081206 SeaMonkey/2.0a3pre - Build ID: 20081206000455

Checkboxes are there on both pref panels (on Linux) => VERIFIED.

REOPEN if the fix doesn't work in the latest nightly for some other platform.
Status: RESOLVED → VERIFIED
Depends on: 469338
Depends on: 469346
You need to log in before you can comment on or make changes to this bug.