467674 - Document new UI from |Bug 467174 - [RFE] Add preferences options for popup and missing plugin infobars|

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Bug 467174 introduces two new checkboxes that control the already existing prefs for whether to display notification bars for blocked popups and missing plugins. This bug is to document the changes to the preferences panes Privacy & Security > Popup Windows and Advanced > Scripts & Plugins.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Help entries for notification bar prefs

Help entries for notification bar prefs

Comment 2

[Stefan [:stefanh]]

I'll look at this in the next few days. I do see that we could hook up the pref help a bit better. When you click on the Help button in the popup pref pane, you end up at the top of cs_priv_prefs_popup.xhtml. If you look in preferences.xul, you'll see that each pane has a helpTopic that corresponds to an ID in suite-toc.rdf. From looking at the code, it seems that we probably should use "pop_up_blocking_prefs" in preferences.xul instead of the currently used "pop_up_blocking". You don't need to come up with a new patch now, though - better wait until I've tried the current one (in case I have some other comments).

Comment 3

[Stefan [:stefanh]]

Comment on attachment 351622 [details] [diff] [review]
Help entries for notification bar prefs

I'm cancelling the request, because the ui have changed a bit. I do have some comments, though. Maybe we could make it a bit more explanatory if we wrote something like this:

"Select this if you want to be informed whenever a website requires additional plugins. If you don't have ... a notification bar, allowing you to download and install the missing plugins, will be displayed above the website content area."

Maybe this is not 100% the right words and too long, but you get the idea :-)

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Help entries for notification bar prefs v2

New patch with comment 2 addressed, a leading whitespace fix, revised wording (hopefully addressing comment 3) and the notification bar added to the section about allowing popups from the current site.

Comment 5

[Stefan [:stefanh]]

I'm not going to be able to look at this until after Christmas.

Comment 6

[Stefan [:stefanh]]

Comment on attachment 354048 [details] [diff] [review]
Help entries for notification bar prefs v2

(Sorry for the delay)

+        area</strong>: When a website requires a certain plugin but you
+        don&apos;t have it installed a notification bar will be displayed
+        above the website content area that allows you to download and install
+        the missing plugin.</li>

"When a website requires a plugin which is not installed, a notification bar will be displayed above the website content area. From the bar you will be able to download and install the missing plugin."



+    Select this to display a notification bar above the website content area
+    whenever a popup is blocked. The bar will allow you to choose what to do with
+    popups from that site.

"Select this to display a notification bar above the website content area whenever a popup is blocked. In the bar, use the Preference button to choose how to handle popups from that website."

+  click the Preferences button on the right end of the notification bar.</p>

Should be "at the right end..."

r=me with those things fixed.

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Attachment: Help entries for notification bar prefs v3, r=stefanh

What Stefan said, but with "Preferences" (the actual button label) instead of "Preference". Carrying over r=stefanh

Comment 8

[Stefan [:stefanh]]

Comment on attachment 355862 [details] [diff] [review]
Help entries for notification bar prefs v3, r=stefanh

You don't need sr for help doc changes. And thanks for catching my "button error" ;-)

Comment 9

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/8a9ba51d5332 (I midaired with you)