Closed Bug 467778 Opened 13 years ago Closed 13 years ago
dragover attribute is not always cleaned up correctly
when we drag over a folder child of a toolbar menu we null out overfolder to avoid closing the parent, but this way we will never unset "dragover" attribute. This is a style issue only, we don't use that dragover for anything other (notice this "dragover" is not the same we set on menupopups)
while there a nit on a wrong comment
Comment on attachment 351190 [details] [diff] [review] patch r=me. please provide STR for QA to verify.
Attachment #351190 - Flags: review?(dietrich) → review+
i tested this on XP where the blu hilight is quite visible. 1. create a new folder A on the bookmarks toolbar 2. create a new folder B inside folder A 3. create a new bookmark C on bookmarks toolbar 4. drag C inside B 5. close all menus, click on A, it should NOT be highlighted as if we were dragging on it
i wrongly removed var parent = popup.parentNode; in previous version, it should be there clearly since we check on it.
Attachment #351190 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 3.1 → Firefox 3.2a1
Comment on attachment 354820 [details] [diff] [review] patch v1.1 asking approval for this polish bug, no risk.
Attachment #354820 - Flags: approval1.9.1?
Comment on attachment 354820 [details] [diff] [review] patch v1.1 a191=beltzner
Attachment #354820 - Flags: approval1.9.1? → approval1.9.1+
verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090127 Shiretoko/3.1b3pre
This bug's priority relative to the set of other polish bugs is: P3 - Polish issue that is in a secondary interface, occasionally encountered, or is not easily identifiable.
Whiteboard: [polish-easy] → [polish-easy][polish-interactive][polish-p3]
You need to log in before you can comment on or make changes to this bug.