418623 - make thunderbird (qute/gnomestripe) use toolkit's tree.css

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Takeshi Kurosawa :takenspc]

Attachment: Patch

Thunderbird Qute theme uses own |tree.css|.

But toolkit has introduced some new features which not coverd by Qute's |tree.css| and Gnomestripe has made trees more gnome-ish.

Basically Qute's |tree.css| is similar to toolkit's one. Let's use toolkit's tree.css

Comment 1

[Takeshi Kurosawa :takenspc]

Comment on attachment 304484 [details] [diff] [review]
Patch

>-      <tree id="folderTree" class="plain focusring" flex="1"
>+      <tree id="folderTree" class="plain" flex="1"

Thunderbird's tree uses |focusring| classes. Qute theme doesn't have any visual effects for them, but toolkit has.
# pinstripe doesn't too.

To use toolkit's tree.css, we should remove this.

Comment 2

[David :Bienvenu]

Comment on attachment 304484 [details] [diff] [review]
Patch

looks OK

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 304484 [details] [diff] [review]
Patch

mail/ doesn't require superreview, but it's just as well: I don't think we want to take this patch, as-is or right now.

Pinstripe *does* have focusrings on trees right now, since it's already using the toolkit tree.css, and it's a bug that Qute doesn't - try to guess where the focus is in Qute when you are in an empty folder with the threadpane focused, or when you've scrolled the selected message in the threadpane out of view, then hit shift-tab a few times, then tab a few times.

This will also lose us our treelines in Qute until we switch to 1.9.1 or bug 430852 lands in 1.9.0.x, and either way we'll need to scatter around some treelines="true" attributes to keep them where we want them.

Comment 4

[Phil Ringnalda (:philor)]

treelines aren't a blocker anymore, and there are two new benefits, pick up the (finally) switched around to platform-native on Windows sort arrows (as soon as Markus remembers to push bug 93772 to 1.9.1) and pick up platform-native twisties on Linux, but switching is going to also give us toolkit's sort-asc.gif and sort-dsc.gif, which look like crap on anything but Windows Classic, where they still don't look native. Be nice to at least have some certainty that bug 467844 is going to land on 1.9.1 before we switch, or at least before we switch our arrows.

Comment 5

[Thomas Stache]

I understand this patch would fix the ugly border around Thunderbird 3's folder and threadpane trees when they have focus? Is the XUL change really depending on the sort indicator icons in bug 467844?

Comment 7

[Thomas Stache]

cc'ing Bryan...
As a lot of theme work is under way, e.g. bug 488840, I'd like to bring this visual polish bug on the table. I have the focus ring removed for me using

.focusring > .tree-stack > .tree-rows > .tree-bodybox {
  border: none !important;
}

in my userChrome.css. Maybe you deem this worth fixing for Thunderbird 3.

Comment 8

[Magnus Melin [:mkmelin]]

Yes, we should get this in for tb3. (I assume bug 467844 will be approved for 1.9.1 soon.)
KUROSAWA-san: are you up for updating the patch? Our gnomestripe theme needs the same changes as the qute ones, and please also hg remove the unneeded files.

Comment 9

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

For hg tip...

Comment 11

[Phil Ringnalda (:philor)]

Comment on attachment 382376 [details] [diff] [review]
proposed fix, v2

Sure.

Comment 12

[Magnus Melin [:mkmelin]]

changeset:   2880:58487656b751
http://hg.mozilla.org/comm-central/rev/58487656b751

->FIXED

Comment 13

[Magnus Melin [:mkmelin]]

changeset:   2881:d2339f2c412c
http://hg.mozilla.org/comm-central/rev/d2339f2c412c