Searches in bookmarks sub-folders of the Library window should default to the context of All Bookmarks ("Search Bookmarks")

RESOLVED FIXED in Firefox 3.5

Status

()

defect
P4
normal
RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: faaborg, Assigned: adw)

Tracking

({polish})

Trunk
Firefox 3.5
Points:
---
Dependency tree / graph
Bug Flags:
wanted-firefox3.5 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][fixed by bug 451151])

Attachments

(1 obsolete attachment)

Currently the search behavior of the Library window is a little strange:

History: Search History
Tags: Search Bookmarks
All Bookmarks: Search Bookmarks
   Bookmarks Toolbar: Search in 'Bookmarks Toolbar'
       Sub-folders; Search Bookmarks
   Bookmarks Menu: Search in 'Bookmarks Menu'
       Sub-folders; Search Bookmarks
   Unfiled Bookmarks: Search in 'Unfiled Bookmarks'
       Sub-folders; Search Bookmarks

For all of the various bookmark folders (various roots and all subfolders) we should default to the widest search possible, "Search Bookmarks."  The parent folder for each search should always be an available context, but never the default context.

Also note bug 469436 for some minor string changes to the context bar.
(Reporter)

Updated

11 years ago
Summary: Searches in bookmarks sub-folders of the Library window should default to the context of "All Bookmarks" → Searches in bookmarks sub-folders of the Library window should default to the context of All Bookmarks ("Bookmarks")
(Reporter)

Updated

11 years ago
Summary: Searches in bookmarks sub-folders of the Library window should default to the context of All Bookmarks ("Bookmarks") → Searches in bookmarks sub-folders of the Library window should default to the context of "All Bookmarks"
Sorry about all the edits to the summary, not sure on the correct summary.  I think it makes sense to use the phrase "Bookmarks" in the search field instead of "All Bookmarks", so: "Search Bookmarks"
Summary: Searches in bookmarks sub-folders of the Library window should default to the context of "All Bookmarks" → Searches in bookmarks sub-folders of the Library window should default to the context of All Bookmarks ("Search Bookmarks")
while working on 3.0 IIRC the request was exactly to make "search in <folder>" the default context when available...
>while working on 3.0 IIRC the request was exactly to make "search in <folder>"
>the default context when available...

yeah, I honestly can't remember what I decided was a good default back then, but defaulting to the folder doesn't seem as useful as a more global bookmark search, since folders don't usually contain so many bookmarks that you would need to do a search.
Target Milestone: --- → Firefox 3.1
Component: Places → Bookmarks & History
Flags: wanted-firefox3.1+
Keywords: polish
Priority: -- → P4
QA Contact: places → bookmarks
Whiteboard: [good first bug]
(Assignee)

Updated

10 years ago
Assignee: nobody → adw
(Assignee)

Comment 4

10 years ago
Posted patch v1 (obsolete) — Splinter Review
This bug raises a couple of issues:

1. If we're defaulting to searching all bookmarks, the label of the "Find in ..." command needs to be updated, too.  It was being updated to "Find in <specific folder>...".  So this patch borrows the OrganizerQueryAllBookmarks property, which in en-us is "All Bookmarks", and the label becomes "Find in All Bookmarks".  At this point might it be better to sync the label with the emptytext of the search box, which reads "Search Bookmarks"?  And now there are only two possibilities for the label: "Find in All Bookmarks" or "Find in History".  Is the "Find in %S ..." property still needed?

2. Until bug 475390 is fixed, it's now impossible to search in bookmarks toolbar, bookmarks menu, and unsorted bookmarks.
Attachment #363213 - Flags: review?(mak77)
(Assignee)

Updated

10 years ago
Depends on: 475390
i'll look at the patch soon, for now commenting on the issues:
> 1. If we're defaulting to searching all bookmarks, the label of the "Find in
> ..." command needs to be updated, too.  It was being updated to "Find in
> <specific folder>...".  So this patch borrows the OrganizerQueryAllBookmarks
> property, which in en-us is "All Bookmarks", and the label becomes "Find in All Bookmarks". At this point might it be better to sync the label with the
> emptytext of the search box, which reads "Search Bookmarks"?  And now there are only two possibilities for the label: "Find in All Bookmarks" or "Find in
> History".  Is the "Find in %S ..." property still needed?

comment 0 and 1 are quite clear on this, it should always read "Search Bookmarks" or "Search History", unless you are on one of the roots, in such a case should be "Search in <root>" (so Search in %s is still useful).
I would not use OrganizerQueryAllBookmarks, because All Bookmarks is the name of the folder in the left pane, i find it confusing for the user. Also because we have some issue transating the left pane folder when locale change (We don't do it indeed). Using emptytext is fine i think, the purpose is the same.

I've not checked all the patch, but rememeber to sync also the filter buttons (scopeBar) that appear when you start the search, so All Bookmarks (at this point should be simply Bookmarks, if possible) is selected correctly instead of <folder>

So 2 things should be updated and in sync, the Search field, and the Scope bar.

> 2. Until bug 475390 is fixed, it's now impossible to search in bookmarks
> toolbar, bookmarks menu, and unsorted bookmarks.

you can fix it here as well if you need it and the code touched is the same, i've seen you've taken it.
and notice in the scope bar we will still have the button "Search: <foldername>", the only difference is that now it is no more the default option.
(Assignee)

Updated

10 years ago
Attachment #363213 - Flags: review?(mak77)
(Assignee)

Comment 7

10 years ago
Related: bug 434704, bug 451151
Depends on: 451151
(Assignee)

Updated

10 years ago
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good first bug] → [good first bug][fixed by bug 451151]
Attachment #363213 - Attachment is obsolete: true
Target Milestone: Firefox 3.1 → Firefox 3.5
You need to log in before you can comment on or make changes to this bug.