The default bug view has changed. See this FAQ.

kill macbrowser ifdefs

RESOLVED FIXED in mozilla7

Status

()

Core
Build Config
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: Robert Kaiser, Assigned: emorley)

Tracking

Trunk
mozilla7
PowerPC
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-cedar, URL)

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
I just ran across some non-macbrowser-defined code in xpfe/components (which we probably should get rid of completely), and decided to see if we still have some of that code left anywhere. The places are scarce, and I really think we should get rid of those. If Camino moves on to being based on mozilla-central one time, they really should use a stock XULRunner as their base, if possible.
(Assignee)

Comment 1

6 years ago
Created attachment 535970 [details] [diff] [review]
Remove MOZ_MACBROWSER

Removes MOZ_MACBROWSER, since it's no longer defined:
http://mxr.mozilla.org/mozilla-central/search?string=MOZ_MACBROWSER

The now removed lines in mozSpellCheckerFactory.cpp were the last users of osxspell, so takes that out too:
http://mxr.mozilla.org/mozilla-central/search?string=OSXSpell
Assignee: nobody → bmo
Status: NEW → ASSIGNED
Attachment #535970 - Flags: review?(benjamin)
(Assignee)

Comment 2

6 years ago
http://dev.philringnalda.com/tbpl/?tree=Try&rev=9709dc3e5f47
Attachment #535970 - Flags: review?(benjamin) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Version: unspecified → Trunk
http://hg.mozilla.org/projects/cedar/rev/f4af0c314193
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: fixed-in-cedar
Target Milestone: --- → mozilla7
http://hg.mozilla.org/mozilla-central/rev/f4af0c314193
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 5

6 years ago
Aaaaah, what please is the reason for completely removing OSXSpell? I use this constantly for my own builds and I love it. And a few bugs I've opened are based on OSXSpell.
(Assignee)

Comment 6

6 years ago
Removing MOZ_MACBROWSER caused it to become dead code per comment 1.

You presumably already had to patch your local build to enable it, so can't you just export the hg revert of this patch and add that to your mq?

Comment 7

6 years ago
(In reply to comment #6)
> You presumably already had to patch your local build to enable it, so can't
> you just export the hg revert of this patch and add that to your mq?
Yes, I had to revert Bug 422760 to enable it. But OK, I also will add this patch to my revert list. Thanks for the hint with mq!
You need to log in before you can comment on or make changes to this bug.