469502 - Email opt-in checkboxes on add-on developers' user pages not checked by default

Status: VERIFIED FIXED

(Infrastructure & Operations Graveyard :: WebOps: Other, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

URL: https://addons.mozilla.org/en-US/firefox/users/edit#profile-notifications

Over in https://bugzilla.mozilla.org/show_bug.cgi?id=465698#c0, fligtar writes:

"both boxes should be checked by default.", referring to the email opt-in functionality:

[X] Add-on Compatibility (strongly recommended)
[X] Upcoming events and contests

which should appear for add-on developers who have at least one add-on on AMO.

However, even with the 4.0.4 push to prod and its SQL having been run, those are not checked by default for those accounts.

Comment 1

[Justin Scott [:fligtar]]

This is still happening in production, and saving the notifications doesn't work.

I'm thinking this a memcache problem or something similar, because it works fine locally but not in production/preview.

We need to fix this ASAP so that we can send out the upcoming email to developers about compatibility.

Mike, can we have someone look at this?

Comment 2

[Wil Clouser [:clouserw]]

This is the same form that is saving all the user info that works fine (and doesn't get caught in memcache).

Comment 3

[Wil Clouser [:clouserw]]

This is fixed on preview - it was missing the database columns.

Production has the columns though and it still doesn't work.  oremj, any ideas?

Comment 4

[Wil Clouser [:clouserw]]

Flipping to IT.

Comment 5

[Dave Miller [:justdave]]

I paged oremj but he hasn't responded yet.  I can probably help if you give me a clue what I need to look for.

Comment 6

[Wil Clouser [:clouserw]]

I've got a feeling it's something to do with the databases.  Cake does a `describe` on the table and then builds a query with what it discovers.

username, last name, etc. are all part of the same <form> and all part of the same query and they are all working fine which leads me to believe that the `describe` that cake is doing isn't returning the right columns.

I've verified and so has oremj that the columns are there (we're talking about the notifycompat and notifyevents columns):  http://oremj.pastebin.mozilla.org/610886

So...this makes me think that what IT is calling production is not what AMO is talking to...?

Comment 7

[Jeremy Orem [:oremj]]

[root@mrapp05 addons.mozilla.org-remora]# cat site/app/config/config.php | grep -e "^define('DB_HOST" -e "^define('DB_NAME'"
define('DB_NAME','addons_$$$$$');
define('DB_HOST','10.2.$$.$$$'); /* tm-amo-master01 */

[oremj@sys ~]$ echo "DESC users;" | ssh 10.2.$$.$$$ mysql addons_remora;
Field	Type	Null	Key	Default	Extra
id	int(11) unsigned	NO	PRI	NULL	auto_increment
email	varchar(255)	YES	UNI	NULL	
password	varchar(255)	NO			
firstname	varchar(255)	NO			
lastname	varchar(255)	NO			
nickname	varchar(255)	NO	MUL		
emailhidden	tinyint(1) unsigned	NO		0	
sandboxshown	tinyint(1) unsigned	NO		0	
homepage	varchar(255)	YES		NULL	
confirmationcode	varchar(255)	NO			
notifycompat	tinyint(1) unsigned	NO	MUL	1	
notifyevents	tinyint(1) unsigned	NO	MUL	1	
created	datetime	NO	MUL	0000-00-00 00:00:00	
modified	datetime	NO		0000-00-00 00:00:00	
notes	text	YES		NULL	
vanilla_role_id	int(11)	NO		3	
vanilla_icon	varchar(255)	YES		NULL	
vanilla_count_discussions	int(11)	YES		0	
vanilla_count_comments	int(11)	YES		0	
vanilla_last_discussion	datetime	YES		0000-00-00 00:00:00	
vanilla_discussion_spam_check	int(11)	YES		0	
vanilla_last_comment	datetime	YES		0000-00-00 00:00:00	
vanilla_comment_spam_check	int(11)	YES		0	
vanilla_comment_format	varchar(20)	YES		TEXT	
vanilla_preferences	text	YES		NULL

Comment 8

[Jeremy Orem [:oremj]]

I think the cake tmp/cache/models were stale.  I cleared it out on all the app servers and am willing to bet this is fixed now.  Let me know if it isn't.

Comment 9

[Justin Scott [:fligtar]]

Yep, fixed now. Thanks.

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; now showing up on https://preview.addons.mozilla.org/en-US/firefox/users/edit#profile-notifications.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

(And, uh, since this wasn't a code fix, I just verified it as fixed on prod too: https://addons.mozilla.org/en-US/firefox/users/edit#profile-notifications.)