469742 - Number textbox doesn't update when first entering a number

Status: RESOLVED DUPLICATE of bug 521644

(Calendar :: Dialogs, defect)

Description

[Decathlon]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; it-IT; rv:1.9.0.4) Gecko/2008102920 Firefox/3.0.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081215 Lightning/1.0pre Shredder/3.0b2pre

Textbox that sets the custom reminder length has two arrow buttons to change reminder length. If you press them, the value inside the textbox changes but the value of the first item in the listbox above the textbox doesn't; moreover the value displayed in the textbox isn't saved closing the dialog.

Reproducible: Always

Steps to Reproduce:
1. create a new event or task;
2. in the reminder dropdown list select "custom...";
3. the textbox in the Custom dialog shows a default reminder length (15 with a new profile); change the value via arrow buttons -> the value in the textbox changes but the first item in the listbox above the Reminder details groupbox doesn't change his value;
4. save the change pressing the OK button

Actual Results:  
The reminder-details link on New Event dialog, still shows the old value for the reminder length; reopening the Custom Reminder dialog, the textbox shows the old value too.

Expected Results:  
Reminder length should be changed.

There isn't any problem using the keyboard.

I've seen that arrow buttons have been added with changes due to bug 405650.
The thextbox has the "type" attribute set to "number" and uses a "oninput" attribute. It seems that "onchange" attribute works fine with arrows button but it doesn't with the keyboard.
I tried to left both "oninput" and "onchange" attributes and the bug disappears except for the first key pressed in the textbox.

Comment 1

[Andreas Treumann]

Bug is also reproducible on Linux and Mac.

Comment 2

[Decathlon]

With the new reminder dialog window and the new textbox of type="number", that sets the reminder length (bug 466288), I can't reproduce this bug anymore.
It works for me.

It remains a minor issue: if you click in the textbox and type, with the keyboard, a number (only one) the corresponding item in reminders list doesn't change and the value showed in the textbox isn't saved. When a second number is typed, the item in the list changes.
I Don't know if this is a normal behavior of the textbox with the property "number" or is a bug.

Comment 3

[Philipp Kewisch [:Fallen][📱📆]]

Attachment: Fix - v1

This may be a toolkit bug. When the first number is entered, then I get an oninput event with the original value, it happens a bit too early. This workaround fixes the issue. I admit its quite hacky, but it does fix the problem. I'm happy to revert this when a toolkit fix comes up, and have filed bug 521644.

Comment 4

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 405756 [details] [diff] [review]
Fix - v1

Actually, I don't think we should introduce this kind of hack. Lets just mark this one duplicate of the toolkit bug and hope its fixed soon.