470348 - clear private data on shutdown does not delete history if "ask me before..." is enabled

Status: VERIFIED FIXED

(Toolkit :: Places, defect, P2)

Description

[Marco Bonardo [:mak]]

Actually clear private data dialog is fired at quit-application, and if options "ask me before..." is enabled work is done there after the user has made a choice.

That does not work anymore because on quit-application Places executes the last sync between memory tables and disk tables and closes the database connection. So we really should move all code that requires a working Places to quit-application-granted.

asking blocking for the obvious fact we are not clearing history on shutdown when requested by the user, so this could potentially be a serious privacy issue.

Comment 1

[Marco Bonardo [:mak]]

this is a 3.1 regression, the issue is obviously not existant in 3.0 since we don't have to sync there.

Comment 2

[Marco Bonardo [:mak]]

well no, the correct bug that regressed is bug 463471, that fixed the case where we clear without "ask me dialog"

Comment 3

[Marco Bonardo [:mak]]

i'm sure there is a bug around that should be duped to this, where Ria commented with a regression range pointing to fsync stuff, but i can't find it anymore now :\

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.1

i added a comment in the history idl about the problem, i need an additional review from dietrich about that, maybe there's a better solution to make implementers aware of that.

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 353765 [details] [diff] [review]
patch v1.1

this seems fine, r=me. gavin might have more perspective on possible side-effects of moving sanitization up to quit-application-granted.

maybe you could add that documentation to a "Places Best Practices" page on MDC?

Comment 8

[Marco Bonardo [:mak]]

i added dev-doc-needed for now, to remember adding the note to MDC.

Comment 9

[Nochum Sossonko [:Natch]]

As Ian pointed out in bug 469158 comment 26, the option this bug addresses no longer exists. Is there still a problem here at all?

Comment 10

[Marco Bonardo [:mak]]

it should be fixed still, yes.

Comment 11

[Dietrich Ayala (:dietrich)]

knocking priority down a notch, given comment 9.

Comment 12

[Nochum Sossonko [:Natch]]

(In reply to comment #11)
> knocking priority down a notch, given comment 9.

I think I was actually wrong there, as the reason the pref was destroyed is because the prompt now *always* shows up, since a time-frame has to be chosen. See bug 469158 comment 28.

Comment 13

[Nochum Sossonko [:Natch]]

(In reply to comment #12)

Sorry for the bugspam, but I was wrong. The dialog will now always show up when you click "Clear Recent History", but never show up when exiting firefox.

Comment 14

[Dietrich Ayala (:dietrich)]

trunk: http://hg.mozilla.org/mozilla-central/rev/053ebdb6a88c

Comment 15

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/00a4e7bf722b

Comment 16

[Marcia Knous [:marcia]]

Regarding the in-litmus nomination, we have a Litmus test case that tests clearing private data, but not after a shutdown. Since the Ask me pref no longer exists, I guess that does not have to be factored in.

Comment 17

[Marcia Knous [:marcia]]

verified fixed on the 1.9.1 branch using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b3pre) Gecko/20090108 Shiretoko/3.1b3pre and  Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090108 Shiretoko/3.1b3pre

verified fixed on the trunk using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090108 Minefield/3.2a1pre and with the latest Vista trunk nightly.

To verify on both I accumulated some history, set the pref to always clear and then restarted to make sure my history was cleared.

Comment 18

[Marco Bonardo [:mak]]

updated both mdc and w.m.o documentations