470468 - Message Header Pane: Subject should be BOLD in both expanded & collapsed states

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Peter Lairo]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.2a1pre) Gecko/20081219 Minefield/3.2a1pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20081219 Lightning/1.0pre Shredder/3.0b2pre

Message Header Pane: Subject should be BOLD in both expanded & collapsed  states

This is a regression from previous releases and even back to Netscape 4. I finf the current expanded header without the bold subject difficult to parse and even irritating.

Reproducible: Always

Comment 1

[Wayne Mery (:wsmwk)]

Is this still true for collapsed?  It seems large enough, whether or not bold. OTOH, I use dpi set to 120. 
 
(expanded doesn't matter to me - I rarely use it except to see stuff that's not in collapsed)

Comment 2

[David Ascher (:davida)]

Not blocking.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Marking blocking because this feels like a win and should be utterly trivial.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Taking.

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 362968 [details] [diff] [review]
proposed fix

excellent!

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 362968 [details] [diff] [review]
proposed fix

r=dmose; however, is the child selector actually necessary?  See the "Rely on Inheritance" section of <https://developer.mozilla.org/en/Writing_Efficient_CSS> for details.

Comment 7

[Magnus Melin [:mkmelin]]

Yes, if you only use #expandedsubjectBox the "subject" word is also bolded, which looked a bit weird.

Comment 8

[Dan Mosedale (:dmosedale, :dmose)]

OK, never mind then.  :-)

Comment 9

[Magnus Melin [:mkmelin]]

changeset:   2088:9a661e3ae8fc
http://hg.mozilla.org/comm-central/rev/9a661e3ae8fc

->FIXED

Comment 10

[Peter Lairo]

Attachment: Screenshot of this bugfix. (and large space befor labels)

Thank you! THANK YOU!  T H A N K   Y O U! :-)

The new header is much more usable now.

BTW: Why is there such a huge wasted empty space before the labels (from, subject, to, etc.)? (see attached screenshot)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b3pre) Gecko/20090227 Lightning/1.0pre Shredder/3.0b3pre

Comment 11

[Magnus Melin [:mkmelin]]

I think the space is needed for longer headers, like "newsgroups" etc.

Comment 12

[Peter Lairo]

Since the longer labels are so rarely used by most users, wouldn't it be better to only move them all out when they actually appear?

Comment 13

[Wayne Mery (:wsmwk)]

please discuss this in a different  bug