470522 - Threadpane context menuitem "Open Message in New Tab" should hide and enable in parallel with "Open Message in New Window"

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Phil Ringnalda (:philor)]

We set up the threadpane context menu so that the New Window menuitem is hidden if more than one message is selected, and shown but disabled if zero messages are selected, but the New Tab menuitem is just always shown, throwing an uncaught exception if nothing's selected and only opening the first message in a tab if multiple items are selected. It'd be lovely if they both just did the right thing with multiple messages selected (which is surely filed, though I didn't find it), but they should at least do the *same* thing, and both hide in shame.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Baby step

Despite the strong temptation to expand out to a half-dozen nearby things that annoy me, this just makes us do the same thing as context-new-window: show for exactly one selected message, which coincidentally is also what we successfully open.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 368753 [details] [diff] [review]
Baby step

Yay for consistency! r=mkmelin

Comment 3

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/00ef42e8b458