470720 - XSS using XPCNativeWrapper and quick stubs

Status: RESOLVED FIXED

(Core :: Security, defect, P1)

Description

[moz_bug_r_a4]

This is trunk/1.9.1 only.

By using XPCNativeWrapper, it's possible to call quick stub
methods/getters/setters on cross-origin objects.

Bug 468552 partially fixes this bug.

Comment 1

[moz_bug_r_a4]

Attachment: testcase 1

This tries to get cookies for www.mozilla.com.
This works on 1.9.1.

On trunk, bug 468552 fixed this testcase.

Comment 2

[moz_bug_r_a4]

Attachment: testcase 2

This tries to get cookies for www.mozilla.com.
This works on trunk and 1.9.1.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Fix

I had confused SJOWs with native wrappers when I allowed native wrappers to unwrap XOWs. SJOWs have a CanAccess check above every call, native wrappers don't. In addition, native wrappers allow themselves to be unwrapped cross-origin, which is what hurts us here.

Comment 4

[Johnny Stenback (:jst)]

Comment on attachment 354231 [details] [diff] [review]
Fix

   // Unwrap a cross origin wrapper, since we're more restrictive than it is.

Since we're no longer unwrapping XOWs, update the comment.

r+sr=jst

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

http://hg.mozilla.org/mozilla-central/rev/abaa242f2300

Comment 6

[chris hofmann]

looks like this should be ready get approval and to go to the branch, right?

is there still time to make the beta?   does it need a beta cycle to catch problems?

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Chris: this bug was subsumed by bug 472792. We shouldn't take it on the branch, but we should take my fix for that bug (which fixes this as well).