Closed
Bug 471493
Opened 16 years ago
Closed 16 years ago
crash [@ nsPropertyTable::GetPropertyInternal(nsPropertyOwner, unsigned short, nsIAtom*, int, unsigned int*)]
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
VERIFIED
FIXED
People
(Reporter: wsmwk, Assigned: surkov)
References
Details
(Keywords: crash, topcrash, verified1.9.1)
Crash Data
Attachments
(1 file)
11.00 KB,
patch
|
MarcoZ
:
review+
rcampbell
:
review+
davidb
:
review+
beltzner
:
approval1.9.1+
|
Details | Diff | Splinter Review |
crash [@ nsPropertyTable::GetPropertyInternal] #1 crasher by far for 3.0b1 and 3.0b2pre, but it might be only a couple people. uptime range is a few seconds to a few hours. bp-1570f8df-8f56-407b-ac6c-298e72081226 nsPropertyTable::GetPropertyInternal content/base/src/nsPropertyTable.cpp:190 nsPropertyTable::GetProperty content/base/src/nsPropertyTable.h:113 nsIFrame::GetProperty layout/generic/nsFrame.cpp:6016 nsIFrame::GetView layout/generic/nsFrame.cpp:3461 nsIFrame::GetClosestView layout/generic/nsFrame.cpp:5499 nsIFrame::GetScreenRectInAppUnits layout/generic/nsFrame.cpp:3568 nsIFrame::GetScreenRect layout/generic/nsFrame.cpp:3553 nsIFrame::GetScreenRectExternal layout/generic/nsFrame.cpp:3548 nsXULTreeAccessible::GetChildAtPoint accessible/src/xul/nsXULTreeAccessible.cpp:336 nsXULTreeAccessible::GetDeepestChildAtPoint accessible/src/xul/nsXULTreeAccessible.cpp:363 nsAccessible::GetChildAtPoint accessible/src/base/nsAccessible.cpp:1154 nsXULTreeAccessible::GetChildAtPoint accessible/src/xul/nsXULTreeAccessible.cpp:352 nsXULTreeAccessible::GetDeepestChildAtPoint accessible/src/xul/nsXULTreeAccessible.cpp:363 nsAccessible::GetChildAtPoint accessible/src/base/nsAccessible.cpp:1154
Comment 1•16 years ago
|
||
or bp-499f3919-79e7-4aea-8524-5d2fc2081226 if you prefer your nsXULTreeAccessible::GetChildAtPoint -> nsPropertyTable::GetPropertyInternal crashes in Firefox rather than Thunderbird.
Component: General → Disability Access APIs
Product: Thunderbird → Core
QA Contact: general → accessibility-apis
Comment 2•16 years ago
|
||
Alex, can you take a look? You reimplemented this function IIRC in the Gecko 1.9.1 timeframe.
Assignee | ||
Updated•16 years ago
|
Assignee: nobody → surkov.alexander
Assignee | ||
Updated•16 years ago
|
Attachment #365143 -
Flags: review?(rcampbell)
Assignee | ||
Comment 6•16 years ago
|
||
Comment on attachment 365143 [details] [diff] [review] patch asking review from Rob for crashtests part
Assignee | ||
Updated•16 years ago
|
Attachment #365143 -
Flags: review?(david.bolter)
Assignee | ||
Updated•16 years ago
|
Status: NEW → ASSIGNED
Updated•16 years ago
|
Attachment #365143 -
Flags: review?(marco.zehe) → review+
Comment 7•16 years ago
|
||
Comment on attachment 365143 [details] [diff] [review] patch r=me for the tests part. Thanks!
Comment 8•16 years ago
|
||
Comment on attachment 365143 [details] [diff] [review] patch This looks like it gets rid of the mutual recursion (stack overflow) thanks! (Will be nice to have layout.js for the bug I'm working on) >+++ b/accessible/tests/mochitest/layout.js >@@ -0,0 +1,55 @@ >+/** >+ * Tests if the given accessible at the given point is expected. >+ * >+ * @param aIdentifier [in] accessible identifier >+ * @param aX [in] x coordinate of the point relative accessible >+ * @param aY [in] y coordinate of the point relative accessible >+ * @param aTakeDeepestChild [in] points whether deepest or nearest child should Nit: I would prefer "findDeepestChild" instead of "aTakeDeepestChild" (find and replace). r=me
Attachment #365143 -
Flags: review?(david.bolter) → review+
Updated•16 years ago
|
Attachment #365143 -
Flags: review?(rcampbell) → review+
Comment 9•16 years ago
|
||
Comment on attachment 365143 [details] [diff] [review] patch this looks ok to me.
Assignee | ||
Comment 10•16 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/acdb66fda343
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•16 years ago
|
Flags: in-testsuite+
Assignee | ||
Updated•16 years ago
|
Attachment #365143 -
Flags: approval1.9.1?
Comment 11•16 years ago
|
||
Comment on attachment 365143 [details] [diff] [review] patch a191=beltzner
Attachment #365143 -
Flags: approval1.9.1? → approval1.9.1+
Assignee | ||
Comment 13•16 years ago
|
||
(In reply to comment #12) > Alexander, are you going to land this on branch? Thank for reminder. Checked in http://hg.mozilla.org/releases/mozilla-1.9.1/rev/65ea3b70fd00
Keywords: fixed1.9.1
Comment 14•16 years ago
|
||
Verified fixed in Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b4pre) Gecko/20090422 Shiretoko/3.5b4pre (.NET CLR 3.5.30729)
Keywords: fixed1.9.1 → verified1.9.1
Reporter | ||
Comment 15•15 years ago
|
||
v.fixed ... no such crashes in 3.0b3 and recent 3.0b3pre nsPropertyTable::GetPropertyInternal(nsPropertyOwner, unsigned short, nsIAtom*, int, unsigned int*)
Status: RESOLVED → VERIFIED
Summary: crash [@ nsPropertyTable::GetPropertyInternal] → crash [@ nsPropertyTable::GetPropertyInternal(nsPropertyOwner, unsigned short, nsIAtom*, int, unsigned int*)]
![]() |
||
Comment 16•15 years ago
|
||
This isn't in-testsuite+: the crashtest.list is not added to the global crashtest manifest. Which is a good thing, since this crashtest uses enablePrivilege and hence would just hang the test machines.
Flags: in-testsuite+ → in-testsuite?
Assignee | ||
Comment 17•15 years ago
|
||
(In reply to comment #16) > This isn't in-testsuite+: the crashtest.list is not added to the global > crashtest manifest. > > Which is a good thing, since this crashtest uses enablePrivilege and hence > would just hang the test machines. Boris, what should I change to avoid hangs?
Comment 19•15 years ago
|
||
(In reply to comment #17) > > Which is a good thing, since this crashtest uses enablePrivilege and hence > > would just hang the test machines. > > Boris, what should I change to avoid hangs? I'd suggest converting the crashtest into a mochitest, since those *can* use enablePrivilege.
Updated•13 years ago
|
Crash Signature: [@ nsPropertyTable::GetPropertyInternal(nsPropertyOwner, unsigned short, nsIAtom*, int, unsigned int*)]
You need to log in
before you can comment on or make changes to this bug.
Description
•