471772 - new mail alert still broken (since RerootFolder() sets "NoMail", but new mail notification window hasn't popped up yet?)

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Magnus Melin [:mkmelin]]

+++ This bug was initially created as a clone of Bug #466784 / bug 462762 +++

re-produce steps
1. open a terminal
2. thunderbird -P 
   create a new profile
3. setup a Gmail IMAP account 
4. login 

expected result:
new mail alert window will popup and new mail info is shown in that window.

actual result
screenshot: https://bugzilla.mozilla.org/attachment.cgi?id=350133

--- 
Bug 462762 comment 6:
I did some investigation on this issue. I think the root cause is in following
snippet in RerootFolder() (mail/base/content/commandglue.js)

  //the new folder being selected should have its biff state get cleared.
  if(newFolder)
  {
    newFolder.biffState =
          Components.interfaces.nsIMsgFolder.nsMsgBiffState_NoMail;
  }

Setting biffState to "NoMail" triggers 
nsMessengerWinIntegration::OnItemIntPropertyChanged() to be called with 
 aNewValue = nsIMsgFolder::nsMsgBiffState_NoMail. So
mFolderWithNewMail->Clear() get called and mFolderWithNewMail gets cleared.

But new mail notification window hasn't poped up yet.

When setting up Gmail IMAP account for the fist time, following codes are
executed:
  if (viewType != nsMsgViewType.eShowVirtualFolderResults &&
(folder.manyHeadersToDownload || showMessagesAfterLoading))
  {
    gRerootOnFolderLoad = true;
    try
    {
      ClearThreadPane();
      SetBusyCursor(window, true);
      folder.startFolderLoading();
      folder.updateFolder(msgWindow);
    }
   ...
 } 
(in ChangeFolder() mail/base/content/commandglue.js).

Because msg db hasn't been created yet, fold.manyHeadersToDownload is "true",
so the "if" condition holds and gRerootOnFolderLoad is set to "true"

Later, in folderListener::OnItemEvent() is triggered with "FolderLoaded" event,
and following snippet is executed:
              if (gRerootOnFolderLoad)
              {
                RerootFolder(uri, msgFolder, gCurrentLoadingFolderViewType,
gCurrentLoadingFolderViewFlags, gCurrentLoadingFolderSortType,
gCurrentLoadingFolderSortOrder);
              }

(in mail/base/content/msgMail3PaneWindow.js:210)

RerootFolder() sets "NoMail", but new mail notification window hasn't popped up
yet.  So the race condition occurs.
---

Comment 1

[Magnus Melin [:mkmelin]]

I still see this occasionally.

Comment 4

[Wayne Mery (:wsmwk)]

(In reply to Magnus Melin [:mkmelin] from comment #1)

I still see this occasionally.

Still?

Comment 5

[Magnus Melin [:mkmelin]]

Not that I recall.