472076 - Changing the layout view when seeing a single message on a tab cause weird behaviors

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Pardal Freudenthal (:ShareBird)]

When I'm seeing a single message on a tab, if I change the layout view: "View" > "Layout", I see very strange behaviors. If I've choose originally the "standard" view and change to "vertical" the message will "disappear" and the main tab will become unusable. 

Steps to reproduce:
1. Open Thunderbird and be sure you are using the "classic" view.
2. Open a single message on a tab.
3. With this tab open, change the view to "vertical".

Results:
The content from this tab will "disappear".
The initial tab will be unusable. 

Expect:
I'd expect no changes on this tab and changes on the main tab (the 3 pane window). Maybe we could disable changes on view in this situation (one single message on the tab).

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

This still happens even with the bug 474701 changes.  We should indeed just disable the layout menu on message tabs.

Comment 2

[palo misik]

I also noticed that there is also problem with codepage detection/setting in Message pane window when you change layout in 3-pane view. 

I reproduced it with message with following encoding:
Content-Type: text/plain;
	charset="koi8-r"
Content-Transfer-Encoding: 8bit

Steps to reproduce:
 1. Open Thunderbird in 3-pane view 
 2. Select message to see content in message pane in 3-pane view
 3. Change Layout to any different
 4. Now you should see message with crazy encoding.

Comment 3

[Rain [:rain1] (inactive)]

Attachment: patch, v1

I think we should move to separate controllers for each tab mode in the future, but for now I think this is reasonable and not too risky.

Comment 4

[Rain [:rain1] (inactive)]

Whoever gets to this first.

Comment 5

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/2990a61158f6